1059991 - [10.10] Focus highlights are incorrect/missing on <select>, <input> and <textarea>

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[:Gijs (he/him)]

In particular, they seem to be missing on:

<select> boxes

they are too small on

<textarea>
<input type="text"> (probably also on password and number fields)

and the location bar and search fields have the wrong style highlight altogether (not entirely sure what's causing that)

Comment 1

[:Gijs (he/him)]

They seem to be missing on <button> and <input type="button"> as well. :-(

Comment 2

[:Gijs (he/him)]

Markus, I think ideally we should fix this before Yosemite ships... any idea what's going on here? :-)

Comment 3

[Markus Stange [:mstange]]

Attachment: do new-style focus drawing on 10.10 even when building against a pre-10.8 SDK

This should at least fix the issue that <select> and <input type="button"> are missing focus rings completely.
https://tbpl.mozilla.org/?tree=Try&rev=559a3fc25205

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8489697 [details] [diff] [review]
do new-style focus drawing on 10.10 even when building against a pre-10.8 SDK

The try build shows focus rings for me, so this seems to do the trick.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8489697 [details] [diff] [review]
do new-style focus drawing on 10.10 even when building against a pre-10.8 SDK

Looks fine to me.

Comment 6

[Markus Stange [:mstange]]

There's bug 821213 about focus rings being too thin on HiDPI in general. If there are remaining bad focus rings after these two patches (the one in this bug + the one in bug 821213) I'll file a new bug to fix those, too.

Comment 7

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d9a3a3061fa

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d9a3a3061fa

Comment 9

[:Gijs (he/him)]

Markus, is this upliftable to Aurora, do you think? Trying to ensure 34 is a workable option for 10.10 users once it gets released. :-)

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 8489697 [details] [diff] [review]
do new-style focus drawing on 10.10 even when building against a pre-10.8 SDK

Good idea, this should be easy to uplift.

Approval Request Comment
[Feature/regressing bug #]: Mac OS 10.10 compatibility
[User impact if declined]: missing focus rings on 10.10
[Describe test coverage new/current, TBPL]: none
[Risks and why]: very low
[String/UUID change made/needed]: none

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8489697 [details] [diff] [review]
do new-style focus drawing on 10.10 even when building against a pre-10.8 SDK

Note that it seems likely from what has been reported that Yosemite will ship before Firefox 34. Aurora+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for Aurora uplift (or approval noms on other blocking bugs).

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Markus - bug 1077365 is still open. What's needed to land this on Aurora?

Comment 14

[Markus Stange [:mstange]]

Nothing, apparently - it looks like Ryan already uplifted it to Aurora successfully:
http://hg.mozilla.org/releases/mozilla-aurora/rev/0162625db84f

(The dependency to bug 1077365 was unrelated to the uplift request, sorry for the confusion.)

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Huh, not sure how that happened...has me a bit worried, TBH.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Current theory is that I may have had two instances of this bug open at the same time, leading to the second uplift attempt conflicting with the first. I've gone through the other 10.10 bugs that were uplifted and they all appear OK and BMO doesn't show any other bugs that got attributed to the Aurora rev in comment 14. So let's let sleeping dogs lie for now :)