1059994 - GMP logging to terminal in nightly builds: "1409255706289 GMPInstallManager.simpleCheckAndInstall INFO Last check was: 10962 seconds ago, minimum seconds: 86400"

Status: RESOLVED DUPLICATE of bug 1049774

(Firefox :: General, defect)

Description

[Daniel Holbert [:dholbert]]

I'm reliably seeing output like this in the terminal where I start my Nightly build, with a fresh profile, pretty soon after startup:
{
1409255706289	GMPInstallManager.simpleCheckAndInstall	INFO	Last check was: 10962 seconds ago, minimum seconds: 86400
1409255706289	GMPInstallManager.simpleCheckAndInstall	INFO	Will not check for updates.
}

I think this logging should be disabled in opt builds, or be behind a pref.  (It looks like we do have a disabled-by-default pref called "media.gmp-manager.log", but it apparently isn't blocking this logging.)

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> I think this logging should be disabled in opt builds, or be behind a pref. 

(I'd argue that it should be disabled in debug builds too, but definitely in opt builds -- opt build terminal-output is pretty quiet, by default, and we should try to keep it that way.)

Comment 2

[Brian R. Bondy [:bbondy]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> (In reply to Daniel Holbert [:dholbert] from comment #0)
> > I think this logging should be disabled in opt builds, or be behind a pref. 
> 
> (I'd argue that it should be disabled in debug builds too, but definitely in
> opt builds -- opt build terminal-output is pretty quiet, by default, and we
> should try to keep it that way.)

Yep I agree, should be disabled in both unless a pref is present. The pref should work independent of the build config though.

Comment 3

[Daniel Holbert [:dholbert]]

OK, cool -- glad we're on the same page. :)

I just tried starting Firefox Nightly with a fresh profile (just an empty directory), and not touching it at all after it started up, and the following appeared in my terminal within 2 minutes:
{
1409287794777	GMPInstallManager.simpleCheckAndInstall	INFO	Last check was: 1409287795 seconds ago, minimum seconds: 86400
1409287794778	GMPInstallManager._getURL	INFO	Using url: https://aus4.mozilla.org/update/3/GMP/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
1409287794779	GMPInstallManager._getURL	INFO	Using url (with replacement): https://aus4.mozilla.org/update/3/GMP/34.0a1/20140828030205/Linux_x86_64-gcc3/en-US/nightly/Linux%203.13.0-34-generic%20(GTK%202.24.23)/default/default/update.xml
1409287794782	GMPInstallManager.checkForAddons	INFO	sending request to: https://aus4.mozilla.org/update/3/GMP/34.0a1/20140828030205/Linux_x86_64-gcc3/en-US/nightly/Linux%203.13.0-34-generic%20(GTK%202.24.23)/default/default/update.xml
1409287795299	GMPInstallManager.onLoadXML	INFO	request completed downloading document
1409287795300	GMPInstallManager.onLoadXML	INFO	allowNonBuiltIn: false
1409287795306	GMPInstallManager.simpleCheckAndInstall	INFO	Found 1 addons advertised.
1409287795306	GMPInstallManager.simpleCheckAndInstall	INFO	Found addon: gmp-gmpopenh264 (isValid: true, isInstalled: false, isOpenH264: true, hashFunction: SHA512, hashValue: d833d27b6d71fce1aa2ad3e59e3def3225ecd1dbbff83fba96e96b36ab8d0b09d1e97f2c226ec546fed04caca5023e8b47950cd01e52cd8306bd0d94f8372f5b, size: 386057)
1409287796284	GMPInstallManager.simpleCheckAndInstall	INFO	Addon installed successfully: gmp-gmpopenh264 (isValid: true, isInstalled: true, isOpenH264: true, hashFunction: SHA512, hashValue: d833d27b6d71fce1aa2ad3e59e3def3225ecd1dbbff83fba96e96b36ab8d0b09d1e97f2c226ec546fed04caca5023e8b47950cd01e52cd8306bd0d94f8372f5b, size: 386057)
}

So, we seem to just be ignoring the logging pref.

Comment 4

[Daniel Holbert [:dholbert]]

(Brian, would you be the right person to take this?)

Comment 5

[Brian R. Bondy [:bbondy]]

Yep np.