[FIX]Framset prints a separate document when printing silently

VERIFIED FIXED in mozilla0.9.6

Status

()

Core
Printing: Output
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: rods (gone), Assigned: rods (gone))

Tracking

({topembed})

Trunk
mozilla0.9.6
x86
Windows 2000
topembed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

16 years ago
Index: nsDocumentViewer.cpp
===================================================================
RCS file: /cvsroot/mozilla/content/base/src/nsDocumentViewer.cpp,v
retrieving revision 1.159
diff -u -r1.159 nsDocumentViewer.cpp
--- nsDocumentViewer.cpp        2001/10/19 20:57:18     1.159
+++ nsDocumentViewer.cpp        2001/10/22 15:53:41
@@ -4435,6 +4435,14 @@
           printf("    DeviceDimension w = %d h = %d\n",i1,i2);

 #endif /* DEBUG_dcone */
+
+          // if there is a frameset and we are printing silently then
+          // the default must be reset kFramesAsIs
+          if (printService && mPrt->mIsParentAFrameSet && aSilent) {
+            mPrt->mPrintFrameType = nsIPrintOptions::kFramesAsIs;
+            printService->SetPrintFrameType(mPrt->mPrintFrameType);
+          }
+
           // Print listener setup...
           if (mPrt != nsnull) {
             mPrt->OnStartPrinting();
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Summary: [FIX]Framset print a separate document when printing silently → [FIX]Framset prints a separate document when printing silently

Comment 1

16 years ago
sr=attinasi for the patch inline in opening comment.
r=kmcclusk@netscape.com

Updated

16 years ago
Blocks: 70229
Keywords: topembed

Comment 3

16 years ago
When this is sr'd, please check it into the 0.9.4 branch.

Thanks.

Updated

16 years ago
Target Milestone: --- → mozilla0.9.6
(Assignee)

Comment 4

16 years ago
checked in on trunk
Sujay: Can you verify that the fix has been checked into the trunk?. Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Keywords: edt0.9.4
Resolution: --- → FIXED

Comment 6

16 years ago
Kevin/Rod, how do I verify this bug?
(Assignee)

Comment 7

16 years ago
Hmmmmm, there isn't anyway to do it with out changing some code (at this time)

Comment 8

16 years ago
Yeah I figured it was a code level verification.

Rod, can you verify this bug for me and mark VERIFIED-FIXED?

thanks.

Comment 9

16 years ago
please check into the 0.9.4 branch, and mark w/ the "fixed0.9.4" keyword when it
lands there.
Keywords: edt0.9.4 → edt0.9.4+
(Assignee)

Comment 10

16 years ago
fixed in branch
Keywords: fixed0.9.4
(Assignee)

Comment 11

16 years ago
verifying
Status: RESOLVED → VERIFIED
(Assignee)

Comment 12

16 years ago
verified on branch

Comment 13

16 years ago
this was verified on the branch on 12/6.

Rod is gonna re-verify it again on recent branch.
Keywords: verified0.9.4

Updated

14 years ago
Keywords: fixed0.9.4
You need to log in before you can comment on or make changes to this bug.