1060230 - CopyPaste Tip overlap with Date/Time Selector

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2014-08-29-12-07-31.png

STR:
1. With the new CopyPaste functionality, copy some text from a textfield.
2. Focus a date/time input field. For example, launch UI Tests app and go to Keyboard page -- there are a few date/time/datetime... inputs available.

Actual Results:
At step 2, the date/time selector shows up and also the "Paste" tip shows on top of the selector (see attached screenshot)

Expected Results:
At step 2, only the date/time selector shows up and not the "Paste" tip.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

The root cause is, inputmethod-contextchange event is fired later than selectionchange, so the text_selection dialog is triggered to launched later than value_selector dialog.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Sorry, inputmethod-contextchange event is earlier, not later.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive,
I'd need your feedback on this patch. The pb is as you have suspected, input-contextchange is fired earlier than selectionchange, that's why text_selection dialog overlap on value_selector dialog. I think there's no direct event to hide text_selection dialog ?

Please let me know if there's any better fix for it. Thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8482524 [details] [review]
PR to master

Please use shown/hidden event.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8482524 [details] [review]
PR to master

Hi Tim,
Since inputmethod-contextchange is fired earlier than selectionchange, text_selection dialog should check if value_selector is already showed or not.
I've addressed comment 4 and added test cases for it.

could you help to review this patch?
Thanks.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/f1dfe20bfaee93e789c31f3604249fa24eb6f3fd