1060245 - [cleanup][bluetooth2] Cleanup headers of manager, adapter, and device

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Add explanation for functions and variables. Also revise with minor changes.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1/3 (v1): Cleanup headers of manager and device

Changes:
- add MOZ_FINAL to FetchUuidsTask
- override operator== of BluetoothDevice to compare devices in adapter (see patch 2/3)
- cleanup headers

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 2/3 (v1): Cleanup header of adapter

Changes:
- add MOZ_FINAL to StartDiscoveryTask
- remove BluetoothDeviceComparator since operator== of BluetoothDevice is overridden.
- cleanup header

Comment 3

[Ben Tian (inactive)]

Attachment: [final] Patch 3/3: Remove BluetoothAdapter::EnableDisable(), r=echou

Changes:
- remove |BluetoothAdapter::EnableDisable|
- revise |BluetoothAdapter::HandleAdapterStateChanged| to |BluetoothAdapter::SetAdapterState|.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8481126 [details] [diff] [review]
Patch 1/3 (v1): Cleanup headers of manager and device

Review of attachment 8481126 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed. Thanks for cleaning up!

::: dom/bluetooth2/BluetoothManager.h
@@ +35,3 @@
>  
> +  /****************************************************************************
> +   * Methods

Methods such as Notify(), AppendAdapter(), WrapObject() are not listed under 'Methods' category, I guess it's because they would not be used by Javascript. If so, can we describe more clear like 'Methods (Web API impl)'?

Comment 5

[Ben Tian (inactive)]

Attachment: [final] Patch 1/3: Cleanup headers of manager and device, r=echou

Revise based on reviewer's comment.

Comment 6

[Ben Tian (inactive)]

Attachment: [final] Patch 2/3: Cleanup header of adapter, r=echou

Revise comment based on comment 4.

Comment 7

[Ben Tian (inactive)]

No try server verification since the modified folder isn't built by default.

--
https://hg.mozilla.org/integration/b2g-inbound/rev/5201b512416d
https://hg.mozilla.org/integration/b2g-inbound/rev/84abb354c07c
https://hg.mozilla.org/integration/b2g-inbound/rev/5437c4229265

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5201b512416d
https://hg.mozilla.org/mozilla-central/rev/84abb354c07c
https://hg.mozilla.org/mozilla-central/rev/5437c4229265