Closed Bug 1060245 Opened 6 years ago Closed 6 years ago

[cleanup][bluetooth2] Cleanup headers of manager, adapter, and device

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S4 (12sep)

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

(Whiteboard: [webbt-api])

Attachments

(3 files, 2 obsolete files)

Add explanation for functions and variables. Also revise with minor changes.
Whiteboard: [webbt-api]
Changes:
- add MOZ_FINAL to FetchUuidsTask
- override operator== of BluetoothDevice to compare devices in adapter (see patch 2/3)
- cleanup headers
Assignee: nobody → btian
Attachment #8481126 - Flags: review?(echou)
Changes:
- add MOZ_FINAL to StartDiscoveryTask
- remove BluetoothDeviceComparator since operator== of BluetoothDevice is overridden.
- cleanup header
Attachment #8481127 - Flags: review?(echou)
Changes:
- remove |BluetoothAdapter::EnableDisable|
- revise |BluetoothAdapter::HandleAdapterStateChanged| to |BluetoothAdapter::SetAdapterState|.
Attachment #8481131 - Flags: review?(echou)
Blocks: 1061481
Comment on attachment 8481126 [details] [diff] [review]
Patch 1/3 (v1): Cleanup headers of manager and device

Review of attachment 8481126 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed. Thanks for cleaning up!

::: dom/bluetooth2/BluetoothManager.h
@@ +35,3 @@
>  
> +  /****************************************************************************
> +   * Methods

Methods such as Notify(), AppendAdapter(), WrapObject() are not listed under 'Methods' category, I guess it's because they would not be used by Javascript. If so, can we describe more clear like 'Methods (Web API impl)'?
Attachment #8481126 - Flags: review?(echou) → review+
Revise based on reviewer's comment.
Attachment #8481126 - Attachment is obsolete: true
Attachment #8481127 - Flags: review?(echou) → review+
Attachment #8481131 - Flags: review?(echou) → review+
Revise comment based on comment 4.
Attachment #8481127 - Attachment is obsolete: true
Attachment #8481131 - Attachment description: Patch 3/3 (v1): Remove BluetoothAdapter::EnableDisable() → [final] Patch 3/3: Remove BluetoothAdapter::EnableDisable(), r=echou
You need to log in before you can comment on or make changes to this bug.