Closed
Bug 1060274
Opened 10 years ago
Closed 10 years ago
[settings] Apn settings: l10n issues
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: arthurcc)
Details
Attachments
(1 file)
- reset-apn should not be used on title and label. - Add New Apn should be Add New APN - The key is called apn-type https://github.com/mozilla-b2g/gaia/blob/93a13e87ff78f96639a68a65a058a1c3002bbc11/apps/settings/elements/apn_editor.html#L56 - The key is called apn-protocol-ipv4v6 Found out another issue unrelated to this patch, worth fixing https://github.com/mozilla-b2g/gaia/blob/93a13e87ff78f96639a68a65a058a1c3002bbc11/apps/settings/elements/apn_editor.html#L66
|
Assignee | |
Comment 1•10 years ago
|
||
Hi EJ, Flod, could you help check the change? Thanks!
Attachment #8481188 -
Flags: review?(ejchen)
Attachment #8481188 -
Flags: feedback?(francesco.lodolo)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8481188 [details] link to https://github.com/mozilla-b2g/gaia/pull/23470 Looks fine to me.
Attachment #8481188 -
Flags: feedback?(francesco.lodolo) → feedback+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8481188 [details] link to https://github.com/mozilla-b2g/gaia/pull/23470 Thanks and r+ !
Attachment #8481188 -
Flags: review?(ejchen) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks for reviewing the patch. master: 0d4a0f7877245c87e508bb5a24e4b393bae82f7d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•