Closed Bug 1060283 Opened 5 years ago Closed 3 years ago

Rename IonSpew to JitSpew

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
firefox49 --- fixed
firefox-esr45 --- fixed
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached patch PatchSplinter Review
A big patch to rename IonSpew* to JitSpew*.

There are some other IonSpew* functions that are only used by Ion, I didn't rename those. This patch also does not rename the IONFLAGS environment variable, I can do that as a follow-up patch.
Attachment #8481169 - Flags: review?(hv1989)
Comment on attachment 8481169 [details] [diff] [review]
Patch

Review of attachment 8481169 [details] [diff] [review]:
-----------------------------------------------------------------

Only one comment. I think it make sense to adjust the log labels to include the "Ion" prefix. (No need to adjust IONFLAGS contents yet. Since that isn't altered in this patch.)

::: js/src/jit/JitSpewer.h
@@ +26,5 @@
>      _(Scripts)                              \
>      /* Info about failing to log script */  \
>      _(Logs)                                 \
>      /* Information during MIR building */   \
>      _(MIR)                                  \

I think it make sense to adjust all passes related to ionmonkey to IonXXX. Like we subdivided BaselineXXX
Attachment #8481169 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/01eeee1da172

(In reply to Hannes Verschore [:h4writer] from comment #1)
> I think it make sense to adjust all passes related to ionmonkey to IonXXX.
> Like we subdivided BaselineXXX

Good idea, leaving this bug open for that (I want to get this patch in first because it bitrots every other day).
Keywords: leave-open
This is just the first part; will do the same for the other channels.

I renamed JitSpew_InlineCaches to JitSpew_IonIC, to match JitSpew_BaselineIC.
Attachment #8488009 - Flags: review?(hv1989)
Comment on attachment 8488009 [details] [diff] [review]
Part 2 - Use JitSpew_Ion*

Review of attachment 8488009 [details] [diff] [review]:
-----------------------------------------------------------------

Ah I was going to ask how you decided which ones to changes and e.g. LICM wasn't adjusted. But that's for next patch IIIC?
Attachment #8488009 - Flags: review?(hv1989) → review+
Part 2:

https://hg.mozilla.org/integration/mozilla-inbound/rev/80164e15bd54

(In reply to Hannes Verschore [:h4writer] from comment #5)
> Ah I was going to ask how you decided which ones to changes and e.g. LICM
> wasn't adjusted. But that's for next patch IIIC?

Yes, just splitting it up a bit. A day later this patch had bitrotted already ;)
No longer blocks: 1307726
Priority: -- → P5
Target Milestone: --- → mozilla35
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.