1060285 - [Music][System] Media playback control buttons on notification tray is broken

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Sherman Chen [:chens] (inactive)]

Attachment: MediaPlaybackControl-before.png

Media playback control show incorrect button on notification tray

Step to reproduce: 
1. Play any music from music app.
2. Pull down notification tray and observe media playback control.

Expected result: 
3. Media playback control display correctly.

Actual result: 
3. Media playback control buttons broken.

Comment 1

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Dominic, 
Could you review this patch? thanks.

Comment 2

[Sherman Chen [:chens] (inactive)]

Attachment: MediaPlaybackControl-after.png

Comment 3

[Marcia Knous [:marcia]]

[Blocking Requested - why for this release]: Noticeable visible regression.

Comment 5

[Dominic Kuo [:dkuo]]

Comment on attachment 8481178 [details] [review]
Pull request

Thanks Sherman, the patch looks good to me, though I didn't actually test it but I believe this should fix it. Also I think it's a regression and would you please help to find the bug that cause this regression? thanks.

Comment 6

[Sherman Chen [:chens] (inactive)]

Attachment: MediaPlaybackControl-update.png

Not seeing this issue on latest master, music widget has new look and maybe also fix this one.