Remove deprecated shared/style/icons.css

RESOLVED WONTFIX

Status

Firefox OS
Gaia
RESOLVED WONTFIX
4 years ago
3 months ago

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The initial shared/style/icons.css icon-font s deprecated in favour of gaia-icons [1]. To avoid further confusion it should be removed.

[1] http://github.com/gaia-components/gaia-icons
(Assignee)

Comment 1

4 years ago
Created attachment 8481176 [details] [review]
pull-request (master)
Attachment #8481176 - Flags: review?(kgrandon)
(Assignee)

Updated

4 years ago
See Also: → bug 1052034
(Assignee)

Updated

4 years ago
Attachment #8481176 - Flags: review?(rnowmrch)
Comment on attachment 8481176 [details] [review]
pull-request (master)

I still see references to this file in calendar?

https://github.com/mozilla-b2g/gaia/blame/master/apps/calendar/index.html#L10
Attachment #8481176 - Flags: review?(kgrandon) → review-
(Assignee)

Comment 3

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #2)
> Comment on attachment 8481176 [details] [review]
> pull-request (master)
> 
> I still see references to this file in calendar?
> 
> https://github.com/mozilla-b2g/gaia/blame/master/apps/calendar/index.html#L10

Ah you're right, not sure how that missed my grepping! I'll migrate calendar as part of this patch. We should see a nice ~50ms startup perf gain from using the new gaia-icons.
(Assignee)

Updated

4 years ago
Depends on: 1065474
Comment on attachment 8481176 [details] [review]
pull-request (master)

Hey Wilson, please ask again for review once Calendar app is fixed.
Attachment #8481176 - Flags: review?(rnowmrch)

Comment 5

3 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.