Closed
Bug 1060300
Opened 10 years ago
Closed 9 years ago
misleading mention of loading strategies in navigate() docs
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: hsteen, Assigned: ato)
References
()
Details
(Keywords: pi-marionette-docs)
Attachments
(1 file)
10.01 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
This should probably be removed: When the refresh period is 1 second or less and the page load strategy is “normal” or “conservative”, it will wait for the page to complete loading before returning.
Assignee | ||
Comment 1•10 years ago
|
||
Matched API docs to reality.
Comment 2•10 years ago
|
||
Comment on attachment 8481259 [details] [diff] [review] 0001-Bug-1060300-Match-Marionette-s-navigation-API-docs-t.patch Review of attachment 8481259 [details] [diff] [review]: ----------------------------------------------------------------- r=me with typo and nit addressed. Also, please remove the '[PATCH 1/1]' prefix on the commit message. ::: testing/marionette/client/marionette/marionette.py @@ +1032,3 @@ > > + In chrome context it will change the current window's location to > + the supplied URL and wait until document.readState equals "complete" readyState? ::: testing/marionette/marionette-server.js @@ +1055,4 @@ > chromeAsyncReturnFunc(error[0], 17, error[1]); > } > }, > + Nit: superfluous whitespace.
Attachment #8481259 -
Flags: review?(dave.hunt) → review+
Updated•9 years ago
|
Keywords: ateam-marionette-docs
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Hallvord R. M. Steen [:hallvors] from comment #3) > ato: forgot to close this bug? ;) This never landed it seems. Rebased and landed it on inbound.
Flags: needinfo?(ato)
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1270c0cd3f5b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•