1060313 - Repo menu links broken when testing ui locally with web-server.js

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P5)

Description

[Ed Morley [:emorley]]

1) Start web-server.js
2) Go to http://localhost:8000/app/index.html?tree=Try#/jobs
3) Open the repo menu
4) Left click on another repo's name (not the checkbox)

Expected:
Switch to that repo

Actual:
URL is incorrect, points to http://localhost:8000/app/#/jobs?repo=mozilla-inbound rather than http://localhost:8000/app/index.html#/jobs?repo=mozilla-inbound

Comment 1

[Ed Morley [:emorley]]

Is web-server.js a workflow we intend to continue to support?
Or is Vagrant (which currently allows for testing of the UI without broken links) going to be necessary?

I must admit it would be great if we could avoid needing a VM to test UI changes... though with Angular html5 URL mode (bug 1042737) it may be unavoidable due to the need for .htaccess redirects etc.

Comment 2

[Ed Morley [:emorley]]

See also the links broken in bug 1109737 comment 4.

Comment 3

[Jonathan French (:jfrench)]

Maybe this bug will be addressed by the planned merging of the -ui and -service repos, but I'll put it up as a good first bug for now.

Comment 4

[Jonathan French (:jfrench)]

(In reply to Ed Morley [:emorley] from comment #1)
> Is web-server.js a workflow we intend to continue to support?
> Or is Vagrant (which currently allows for testing of the UI without broken
> links) going to be necessary?
> 
> I must admit it would be great if we could avoid needing a VM to test UI
> changes... though with Angular html5 URL mode (bug 1042737) it may be
> unavoidable due to the need for .htaccess redirects etc.

I'm beginning think the same as Ed here. With the repo unification, and the relative ease of setting up vagrant (we've ironed out out most of the setup kinks on each platform and include it in Troublshooting in RTD) and using run_gunicorn to serve locally (where all the Treeherder UI links work), I am thinking we should consider retiring web-server.js?

I noticed also yesterday navigating from Perfherder back to Treeherder via it's new top left logo-navigation-menu, suffers from the same problem as repo switching, with web-server.js.

But it works perfectly running vagrant w/gunicorn.

Comment 5

[Ed Morley [:emorley]]

Fixing the repo menu is easy - let's do that for now.

There are another two broken links: the link back from the log viewer to the main view, and also from perfherder to the main view. The hard part it's not overly easy for the logviewer/perfherder pages to tell whether they need to link to '/index.html' or '/', unless we hardcode checking for localhost. Unfortunately the stage/prod apache configs don't redirect index.html to '/' otherwise we could just always link to index.html and let the redirect work if needs be (ie when not using web-server.js). In another bug we can always do that - but seeing as the apache configs are controlled by IT's puppet, it's going to be more involved, so not going to do that here.

Comment 6

[Ed Morley [:emorley]]

Attachment: Fix the repo menu links when using web-server.js

Comment 7

[Ed Morley [:emorley]]

(In reply to Ed Morley [:emorley] from comment #5)
> Unfortunately the stage/prod apache configs don't redirect index.html to '/'
> otherwise we could just always link to index.html and let the redirect work
> if needs be (ie when not using web-server.js). In another bug we can always
> do that - but seeing as the apache configs are controlled by IT's puppet,
> it's going to be more involved, so not going to do that here.

Ah I've just thought of a better idea: bug 1168770.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ea0207557e1893239b977ea64faf2a3d420fece1
Bug 1060313 - Fix the repo menu links when using web-server.js