Somewhat misleading and confusing message from async animation in nsDisplayList.cpp

RESOLVED FIXED in mozilla35

Status

()

Core
Layout
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: milan, Assigned: milan)

Tracking

26 Branch
mozilla35
x86
All
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

When the animations are logged, the user may get a "Async animation disabled because frame size ... is bigger than the viewport ..." even when the frame size is smaller than the viewport - because the size of the visual rectangle goes beyond the current maximum (4096 dev pixels.)
Assignee: nobody → milan
Created attachment 8481372 [details] [diff] [review]
More descriptive message when async animation is not being done.
Attachment #8481372 - Flags: review?(tnikkel)
No rush whatsoever on this review, it's obviously just a minor thing.
Comment on attachment 8481372 [details] [diff] [review]
More descriptive message when async animation is not being done.

Can we use just one variable to hold 4096 dev pixels in app units? So they don't get out of sync if we ever change it.
Attachment #8481372 - Flags: review?(tnikkel) → review+
(In reply to Timothy Nikkel (:tn) from comment #3)
> Comment on attachment 8481372 [details] [diff] [review]
> More descriptive message when async animation is not being done.
> 
> Can we use just one variable to hold 4096 dev pixels in app units? So they
> don't get out of sync if we ever change it.

Good idea, will do.

https://tbpl.mozilla.org/?tree=Try&rev=f57a9516099d
Created attachment 8489450 [details] [diff] [review]
More descriptive message when async animation is not being done.  Carry r=tnikkel.

With review comments addressed.
Attachment #8489450 - Flags: review+
Attachment #8481372 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c061af84898d
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c061af84898d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.