Closed Bug 1060452 Opened 5 years ago Closed 5 years ago

Add generic-failure string for Loop clients

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox34 fixed)

RESOLVED FIXED
mozilla34
Iteration:
34.3
Tracking Status
firefox34 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 1002416 handles the ability to surface errors to the person using Loop, but will need to have some text to show the person. We need to make sure to get the string in to mozilla-central before aurora uplift, so this bug is just about getting that string in and then bug 1002416 (or a latter bug) can reference it.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8481403 - Flags: review?(adam)
Depends on: 1002416
Attachment #8481403 - Flags: review?(adam) → review?(standard8)
Attached patch Patch (obsolete) — Splinter Review
Added another string I didn't see in my first pass.
Attachment #8481403 - Attachment is obsolete: true
Attachment #8481403 - Flags: review?(standard8)
Attachment #8481590 - Flags: review?(standard8)
I guess the previous patch was uploaded before qref finished and didn't include the other string. It should be in this version.
Attachment #8481590 - Attachment is obsolete: true
Attachment #8481590 - Flags: review?(standard8)
Attachment #8482066 - Flags: review?(standard8)
Attachment #8482066 - Flags: review?(standard8) → review?(MattN+bmo)
Comment on attachment 8482066 [details] [diff] [review]
Patch (with other string)

Review of attachment 8482066 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +34,5 @@
>  cannot_start_call_session_not_ready=Can't start call, session is not ready.
>  network_disconnected=The network connection terminated abruptly.
> +connection_error_see_console_notification=Call failed; see console for details.
> +generic_failure_with_reason=Something went wrong. You can try again or email a link to be reached at later.
> +generic_failure_no_reason=Something went wrong. Would you like to try again?

I haven't looked but is there buttons strings to respond to this question?
Attachment #8482066 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/integration/fx-team/rev/61b046e65d02

(In reply to Matthew N. [:MattN] from comment #4)
> > +generic_failure_no_reason=Something went wrong. Would you like to try again?
> 
> I haven't looked but is there buttons strings to respond to this question?

Good question. I looked back at the slides and there was a "Retry" string as well as a "Report User" string that I couldn't find in the l10n files. I added them to this patch before checking it in.
Whiteboard: [fixed in fx-team]
Flags: qe-verify-
Flags: firefox-backlog+
Iteration: 34.3 → 35.1
https://hg.mozilla.org/mozilla-central/rev/61b046e65d02
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla34
Iteration: 35.1 → 34.3
You need to log in before you can comment on or make changes to this bug.