1060462 - race in test_settings_change_language

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

In some cases on the spritely desktopb2g , gaiatest can tap on the <select> box language.current before it was been filled with data.

This causes the System wrapper to open with 0 options in it and thus the test fails.

I'll pop an extra wait for the javascript to have done its stuff.

Comment 1

[Zac C (:zac)]

Attachment: github pr

The number of options can vary depending upon the profile configuration but during my debugging I saw the number of options jump from 0 straight to 4 in one step, perhaps to do with the way they are inserted into the DOM.

This test will be sensitive to the machine that's running the test which is why we mostly only see it on the fast TBPL machines.

qdot, can you give this a spin together with your patch on the machine you saw it intermittently? Otherwise we'll pick it up on Monday.

You can add --repeat 50 to the gaiatest command line and run it to get a good result sample. Probably important to use --restart too, to be sure the html is not just cached.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

So, uh, you didn't yank this out of tbpl's test manifest or land anything did you? Because I landed settings and... Gip is either oranging on different issues, or green? 

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=6b1690ad2cf5

Comment 3

[Kevin Grandon :kgrandon]

In master, let's see what this does.

https://github.com/mozilla-b2g/gaia/commit/b12f88dd94f228b94e44a769788006a4b59c068c