Intermittent test_profile_client.js | test failed (with xpcshell return code: 0) | false == true

RESOLVED FIXED in Firefox 34

Status

()

defect
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: RyanVM, Assigned: vladikoff)

Tracking

({intermittent-failure})

unspecified
Firefox 34
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox32 unaffected, firefox33 unaffected, firefox34 fixed, firefox-esr31 unaffected)

Details

Attachments

(1 attachment, 2 obsolete attachments)

https://tbpl.mozilla.org/php/getParsedLog.php?id=47033756&tree=Mozilla-Inbound

Windows 7 32-bit mozilla-inbound opt test xpcshell on 2014-08-29 08:29:27 PDT for push 36cedce0c8b3
slave: t-w732-ix-047

08:47:00     INFO -  TEST-INFO | C:\slave\test\build\tests\xpcshell\tests\services\fxaccounts\tests\xpcshell\test_profile_client.js | running test ...
08:47:02  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\services\fxaccounts\tests\xpcshell\test_profile_client.js | test failed (with xpcshell return code: 0), see following log:
08:47:02     INFO -  >>>>>>>
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 0 pending (2)
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test MAIN run_test finished (2)
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | running event loop
08:47:02     INFO -  TEST-INFO | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | Starting successfulResponse
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test successfulResponse pending (2)
08:47:02     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Initialized
08:47:02     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Requested profile
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 0 finished (2)
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [successfulResponse/< : 63] "someone@restmail.net" == "someone@restmail.net"
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [successfulResponse/< : 64] "0d5c1a89b8c54580b8e3e8adadae864a" == "0d5c1a89b8c54580b8e3e8adadae864a"
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 1 pending (2)
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test successfulResponse finished (2)
08:47:02     INFO -  TEST-INFO | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | Starting parseErrorResponse
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test parseErrorResponse pending (2)
08:47:02     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Initialized
08:47:02     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Requested profile
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 1 finished (2)
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [parseErrorResponse/< : 83] "FxAccountsProfileClientError" == "FxAccountsProfileClientError"
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [parseErrorResponse/< : 84] 200 == 200
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [parseErrorResponse/< : 85] 997 == 997
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [parseErrorResponse/< : 86] "PARSE_ERROR" == "PARSE_ERROR"
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [parseErrorResponse/< : 87] "unexpected" == "unexpected"
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 2 pending (2)
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test parseErrorResponse finished (2)
08:47:02     INFO -  TEST-INFO | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | Starting serverErrorResponse
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test serverErrorResponse pending (2)
08:47:02     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Initialized
08:47:02     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Requested profile
08:47:02     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 2 finished (2)
08:47:02     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [serverErrorResponse/< : 105] "FxAccountsProfileClientError" == "FxAccountsProfileClientError"
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [serverErrorResponse/< : 106] 401 == 401
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [serverErrorResponse/< : 107] 100 == 100
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [serverErrorResponse/< : 108] "Bad Request" == "Bad Request"
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [serverErrorResponse/< : 109] "Unauthorized" == "Unauthorized"
08:47:03     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 3 pending (2)
08:47:03     INFO -  TEST-INFO | (xpcshell/head.js) | test serverErrorResponse finished (2)
08:47:03     INFO -  TEST-INFO | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | Starting networkErrorResponse
08:47:03     INFO -  TEST-INFO | (xpcshell/head.js) | test networkErrorResponse pending (2)
08:47:03     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Initialized
08:47:03     INFO -  FirefoxAccounts	DEBUG	FxAccountsProfileClient: Requested profile
08:47:03     INFO -  Services.Common.RESTRequest	TRACE	HTTP Header authorization: ***** (suppressed)
08:47:03     INFO -  Services.Common.RESTRequest	TRACE	HTTP Header accept: application/json
08:47:03     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 3 finished (2)
08:47:03     INFO -  Services.Common.RESTRequest	TRACE	onStartRequest: GET http://profile/
08:47:03     INFO -  Services.Common.RESTRequest	TRACE	Channel for GET http://profile/ returned status code 2147500036
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [networkErrorResponse/< : 124] "FxAccountsProfileClientError" == "FxAccountsProfileClientError"
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [networkErrorResponse/< : 125] null == null
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [networkErrorResponse/< : 126] 998 == 998
08:47:03     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | [networkErrorResponse/< : 127] "NETWORK_ERROR" == "NETWORK_ERROR"
08:47:03  WARNING -  TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js | false == true - See following stack:
08:47:03     INFO -  C:/slave/test/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_profile_client.js:networkErrorResponse/<:128
08:47:03     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:868
08:47:03     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:744
08:47:03     INFO -  C:\\slave\\test\\build\\tests\\xpcshell\\head.js:_do_main:191
08:47:03     INFO -  C:\\slave\\test\\build\\tests\\xpcshell\\head.js:_execute_test:405
08:47:03     INFO -  -e:null:1
08:47:03     INFO -  null:null:0
08:47:03     INFO -  TEST-INFO | (xpcshell/head.js) | exiting test
08:47:03     INFO -  <<<<<<<
Flags: needinfo?(vlad)
I removed the strict assertion that we have in the tests. We mostly care about the structured error object and other tests handle that. I'm attaching the new patch to this bug, let me know if I should do anything else.
Attachment #8481415 - Flags: feedback?(MattN+bmo)
Flags: needinfo?(vlad)
Oh it seems 1058424 is already in mozilla-central, I'm assuming I should create a new patch.
Updated as its own patch.
Assignee: nobody → vlad
Attachment #8481415 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8481415 - Flags: feedback?(MattN+bmo)
Attachment #8481435 - Flags: review?(MattN+bmo)
Attachment #8481435 - Flags: review?(MattN+bmo) → review+
seems this patch doesn't apply cleanly:

patching file services/fxaccounts/tests/xpcshell/test_profile_client.js
Hunk #1 FAILED at 119
1 out of 1 hunks FAILED -- saving rejects to file services/fxaccounts/tests/xpcshell/test_profile_client.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0001-Bug-1058424-Fixes-network-error-tests-in-the-FxA-Pro.patch

could you take a look and maybe it would be cool if you could provide a try link! Thanks!
Flags: needinfo?(vlad)
Keywords: checkin-needed
Rebased the patch against latest changes. Hope this helps!
Attachment #8481435 - Attachment is obsolete: true
Flags: needinfo?(vlad)
(In reply to Carsten Book [:Tomcat] from comment #5)
> seems this patch doesn't apply cleanly:

That's because it got landed with the wrong bug number already in: 
https://hg.mozilla.org/integration/fx-team/rev/8d48127a01e3
http://hg.mozilla.org/mozilla-central/rev/8d48127a01e3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Firefox
Target Milestone: mozilla34 → Firefox 34
You need to log in before you can comment on or make changes to this bug.