Closed Bug 1060541 Opened 6 years ago Closed 6 years ago

[Lockscreen] Adding 1 additional notification to lockscreen with new music player

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(b2g-v2.1 affected, b2g-v2.2 verified)

VERIFIED FIXED
2.1 S5 (26sep)
Tracking Status
b2g-v2.1 --- affected
b2g-v2.2 --- verified

People

(Reporter: amylee, Assigned: mnjul)

References

Details

(Whiteboard: ux-tracking, visual design, jian [p=2])

Attachments

(10 files)

Work is being done in Bug 1038723 with implementing a new music player on lockscreen so it's consistent with the new music player in the 2.1 notifications tray.

The new music player has a shorter height and so we are able to fit an additional notification on the screen when music player is on lockscreen. Originally on 320x480 screen sizes we had disabled notification scrolling when music player is on due to the small scrolling area. With the new shorter music player, we can now enable scrolling since we can fit 2 notifications instead of 1 on 320x480 devices when music player is on.
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.1?
blocking-b2g: 2.1? → ---
Assignee: nobody → jlu
Whiteboard: ux-tracking, visual design, jian → ux-tracking, visual design, jian [p=1]
Target Milestone: --- → 2.1 S4 (12sep)
John, is this bug really depend on bug 1038723?
Flags: needinfo?(jlu)
Yes. However it's quite unrelated to the notification styling changes brought by bug 1038723. It's the music player widget that changed size in bug 1038723 so lockscreen's notification container would have position/dimension changes.

Please feel free to do anything to this bug as the WIP patch is just some non-precise CSS changes done within half-an-hour to make sure modifications of this bug have low chance to regress anything further.
Flags: needinfo?(jlu)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Both bug 1038723 and bug 1055577 seem stable now. Patch is here but I'll wait for another day or two to make sure those two bugs aren't backed-out again, before asking for review.
Attachment #8482119 - Attachment description: WIP Patch (PR @ GitHub) → Patch (PR @ GitHub)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Hi Amy,

There are now two notifications showing in lockscreen with music player widget displayed, on HVGA devices. The notifications are now scrollable too.

Notifications container for (non-HVGA) normal-sized screens have also been adjusted.

Please check if things look good for you. Thanks!
Attachment #8482119 - Flags: ui-review?(amlee)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Hi John, 

Here is my feedback:

1. Flame: When music player is on, can you please move the notifications down by 29px? We are running into overlap issues when the (no sim) card message is present (see attached).

2. When there more than 4 notifications and you scroll to the bottom, the top notification gets cut off (see attached).

3. On 320x480 devices: Can you please move time/date up 5px? See attached screen

4. On 320x480 devices: move "(no SIM)" message to line above so there is more room for notifications. This change will need to have string length approval. NI Rob to see who needs to approve this. 

Also adding Rob for UI review. 

Thank you
Attachment #8482119 - Flags: ui-review?(rmacdonald)
Flags: needinfo?(rmacdonald)
Attachment #8482119 - Flags: ui-review?(amlee) → ui-review-
Flame edits
320x480 device edits
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Hi Amy,

Please check if the updated patch has correctly addressed issues in comment 3, except for issue 4 (moving up No Sim line). Please do note that for 320x480 devices, since the No Sim line has not been moved, but the Date/Time has been moved up, their distance appears closer than expected. This should be resolved once we proceed to move up the No Sim line.


For Greg,

I added the logics [decide which index should be the "visually top" according to screen resolution and the presence of music player widget] directly in LockscreenNotificationBuilder [1], but I tend to think such codes should be placed in lockscreen_notifications.js that exposes such function -- yet to do so we'd need to pass in the instance of |lockScreenNotifications| when we |start()| the builder, which means more changes and more potential conflicts. Shall I do that (placing the codes in l_n.js and alter |start()| of the builder) in this patch?

[1] https://github.com/mozilla-b2g/gaia/pull/23551/files#diff-6135d6f8db5c2e91b833510408637c9f
Attachment #8482119 - Flags: ui-review?(amlee)
Attachment #8482119 - Flags: ui-review-
Attachment #8482119 - Flags: feedback?(gweng)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Hi John, 

Thanks for making the changes.

Here is my feedback:

1. The font on the time stamp in the notifications looks like it has been changed from Fira Sans regular to bold weight. Can you please change this back to regular weight? (see attached screenshot) 

2. The arrow graphic for more notifications looks fuzzy on the Flame device.

3. When I have notifications on lockscreen and I restart the phone, the notifications remain on the screen when the phone restarts but the background overlay is missing (see screenshot) NI Rob to confirm correct behaviour.
Attachment #8482119 - Flags: ui-review?(rmacdonald)
Attachment #8482119 - Flags: ui-review?(amlee) → ui-review-
Attached image Lockscreen_Edit_v2.png
Timestamp should be Fira Sans regular and not bold. Thanks
Attached image 2014-09-02-08-13-46.png
screenshot for reference. When phone restarts, notifications are still present but background overlay is missing.
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Minusing based on Amy's earlier comments. Please flag me when the next patch is available. Thanks!
Attachment #8482119 - Flags: ui-review?(rmacdonald)
Attachment #8482119 - Flags: ui-review-
Flags: needinfo?(rmacdonald)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

(In reply to Amy Lee [:amylee] from comment #11)
> 1. The font on the time stamp in the notifications looks like it has been
> changed from Fira Sans regular to bold weight. Can you please change this
> back to regular weight? (see attached screenshot) 

Okies, I changed that.
 
> 2. The arrow graphic for more notifications looks fuzzy on the Flame device.

From what I can see in your screenshot, all the graphics are fuzzy and I guess you missed GAIA_DEV_PIXELS_PER_PX=1.5 when you flashed Flame.
 
> 3. When I have notifications on lockscreen and I restart the phone, the
> notifications remain on the screen when the phone restarts but the
> background overlay is missing (see screenshot) NI Rob to confirm correct
> behaviour.

It's on my list with bug 1058447 and we'll deal with it separately.

--

So Amy, please check if the timestamp font weight looks good now. We will investigate the overlay issue in bug 1058447 (it's just some JS functionality problems). Also, do we have a final decision on moving up No Sim line for 320x480 devices? Thanks.
Attachment #8482119 - Flags: ui-review- → ui-review?(amlee)
Flags: needinfo?(amlee)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

The code seems OK if you needn't too much further changes to pass the ui-review.
Attachment #8482119 - Flags: feedback?(gweng) → feedback+
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Thanks for fixing the font! Everything looks good now. 

Flagging Rob for UI review and also NI Rob for who to get approval for string length for moving the (No Sim) text to the line above.
Attachment #8482119 - Flags: ui-review?(amlee) → ui-review+
Flags: needinfo?(amlee) → needinfo?(rmacdonald)
(In reply to Amy Lee [:amylee] from comment #9)
> Created attachment 8483758 [details]
> Lockscreen_edits_320x480.png
> 
> 320x480 device edits

Hi Steph, 

We would like to move the "(No Sim)" line in lockscreen to the line above it so we have more room for notifications on lockscreen (see attached screenshot in comment 9). We want to check if string length would be an issue if we do this so seeking approval from L10N. 

Thanks!
Flags: needinfo?(rmacdonald)
See above comment ^^
Flags: needinfo?(swilkes)
Attachment #8482119 - Flags: ui-review?(rmacdonald)
(In reply to John Lu [:mnjul] [MoCoTPE] from comment #15)
> Comment on attachment 8482119 [details] [review]
> Patch (PR @ GitHub)
> 
> (In reply to Amy Lee [:amylee] from comment #11)
> > 1. The font on the time stamp in the notifications looks like it has been
> > changed from Fira Sans regular to bold weight. Can you please change this
> > back to regular weight? (see attached screenshot) 
> 
> Okies, I changed that.
>  
> > 2. The arrow graphic for more notifications looks fuzzy on the Flame device.
> 
> From what I can see in your screenshot, all the graphics are fuzzy and I
> guess you missed GAIA_DEV_PIXELS_PER_PX=1.5 when you flashed Flame.
>  
> > 3. When I have notifications on lockscreen and I restart the phone, the
> > notifications remain on the screen when the phone restarts but the
> > background overlay is missing (see screenshot) NI Rob to confirm correct
> > behaviour.
> 
> It's on my list with bug 1058447 and we'll deal with it separately.
> 
> --
> 
> So Amy, please check if the timestamp font weight looks good now. We will
> investigate the overlay issue in bug 1058447 (it's just some JS
> functionality problems). Also, do we have a final decision on moving up No
> Sim line for 320x480 devices? Thanks.

Hi John, 

I spoke to Steph and she said we can go ahead with moving the (No Sim) to the line above. She said that there is the possibility that this won't get into 2.1 and so it will go into 2.2 since we missed string freeze by a few days. If this change doesn't get into 2.1 can we please stick with one notification and no scrolling when music player is on a 320x480 device (how we previously had it). Thanks
I don't think this qualifies as a string change. Is this not just taking two strings and re-arranging their position to one another?
Flagging Delphine to see if she knows if this is actually a string change, since both strings already exist in the system today, and visual positioning is changing (vs. two strings becoming literally one).
Flags: needinfo?(swilkes) → needinfo?(lebedel.delphine)
I admit that I'm unclear with what's happening exactly here.
Basically what I can say is: if you're touching at a .properties file, then there is a string impact. If strings are moved at all, then there is string impact also. So it would be considered as a string change
Flags: needinfo?(lebedel.delphine)
(In reply to Amy Lee [:amylee] from comment #20)

> Hi John, 
> 
> I spoke to Steph and she said we can go ahead with moving the (No Sim) to
> the line above. She said that there is the possibility that this won't get
> into 2.1 and so it will go into 2.2 since we missed string freeze by a few
> days. If this change doesn't get into 2.1 can we please stick with one
> notification and no scrolling when music player is on a 320x480 device (how
> we previously had it). Thanks

Confirming on behalf of IxD - Thanks Amy!

Also, flagging Axel and Delphine as this does seem like a string change. Putting the two strings side by side creates the possibility of concatenation errors, which we'd obviously like to avoid. 

Please review the attachment "Lockscreen_edits_320x480.png" and let us know if the "Emergency calls only" and "(no SIM)" strings can be moved to the same line. Putting them on the same line will allow us to have two notifications on the lock screen during music playback instead of just one.

Also flagging Amy to confirm the accuracy of my statements.
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(l10n)
Flags: needinfo?(amlee)
(In reply to Amy Lee [:amylee] from comment #20)
> (In reply to John Lu [:mnjul] [MoCoTPE] from comment #15)
> > Comment on attachment 8482119 [details] [review]
> > Patch (PR @ GitHub)
> > 
> > (In reply to Amy Lee [:amylee] from comment #11)
> > > 1. The font on the time stamp in the notifications looks like it has been
> > > changed from Fira Sans regular to bold weight. Can you please change this
> > > back to regular weight? (see attached screenshot) 
> > 
> > Okies, I changed that.
> >  
> > > 2. The arrow graphic for more notifications looks fuzzy on the Flame device.
> > 
> > From what I can see in your screenshot, all the graphics are fuzzy and I
> > guess you missed GAIA_DEV_PIXELS_PER_PX=1.5 when you flashed Flame.
> >  
> > > 3. When I have notifications on lockscreen and I restart the phone, the
> > > notifications remain on the screen when the phone restarts but the
> > > background overlay is missing (see screenshot) NI Rob to confirm correct
> > > behaviour.
> > 
> > It's on my list with bug 1058447 and we'll deal with it separately.
> > 
> > --
> > 
> > So Amy, please check if the timestamp font weight looks good now. We will
> > investigate the overlay issue in bug 1058447 (it's just some JS
> > functionality problems). Also, do we have a final decision on moving up No
> > Sim line for 320x480 devices? Thanks.
> 
> Hi John, 
> 
> I spoke to Steph and she said we can go ahead with moving the (No Sim) to
> the line above. She said that there is the possibility that this won't get
> into 2.1 and so it will go into 2.2 since we missed string freeze by a few
> days. If this change doesn't get into 2.1 can we please stick with one
> notification and no scrolling when music player is on a 320x480 device (how
> we previously had it). Thanks

Just some notes: If the No Sim thing is determined as string change, it is still possible that I make a 2.1-based patch that keeps [one & unscrollable notification on 320x480 screen with music widget] while also incorporates other fixes in this patch [one more notification on Flame screen with music widget; position adjustments on Flame], and that I utilize a follow-up bug to address the string change that lands only in 2.2 -- these can be carried out without complicating engineering process too much.
Trying to understand: you don't plan to add a new string, but you want to move visually the existing "(no SIM)" string and display it to the same line of "Emergency call only".

Technically it's not breaking string freeze, but I would advise against it at this point in the cycle for 2.1

http://transvision-beta.mozfr.org/string/?entity=apps/system/system.properties:emergencyCallsOnly&repo=gaia_2_0
http://transvision-beta.mozfr.org/string/?entity=apps/system/system.properties:emergencyCallsOnly-noSIM&repo=gaia_2_0

Main issue: length. Can you ensure us that these 2 strings will fit on one line? Some examples:

en-US: "Emergency calls only" + "(no SIM)"
fr:    "Appels d’urgence uniquement" + "(aucune carte SIM)"
it:    "Solo chiamate d’emergenza" + "(SIM non presente)"
pt-BR: "Apenas Chamadas de Emergência" + "(sem cartão SIM)"
zu:    "Izingcingo eziphuthumayo kuphela" + "(akukho SIM)"

Semantically, looking at how these 2 strings are translated, I don't think it would be an issue to display them on the same line (no trailing periods in the 1st, "( message )" in all locales for the 2nd), but I also speak/read only a couple of languages ;-)
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(l10n)
Attached image 2014-09-09-14-36-05.png
(In reply to Francesco Lodolo [:flod] from comment #26)
> Main issue: length. Can you ensure us that these 2 strings will fit on one
> line? Some examples:
> 
> en-US: "Emergency calls only" + "(no SIM)"
> fr:    "Appels d’urgence uniquement" + "(aucune carte SIM)"
> it:    "Solo chiamate d’emergenza" + "(SIM non presente)"
> pt-BR: "Apenas Chamadas de Emergência" + "(sem cartão SIM)"
> zu:    "Izingcingo eziphuthumayo kuphela" + "(akukho SIM)"
> 

Ahhhh. No, we can't. Please see the attached screenshot, a mockup I made with the French strings, they're way longer than what the screen width can provide.
(In reply to Rob MacDonald [:robmac] from comment #24)
> (In reply to Amy Lee [:amylee] from comment #20)
> 
> > Hi John, 
> > 
> > I spoke to Steph and she said we can go ahead with moving the (No Sim) to
> > the line above. She said that there is the possibility that this won't get
> > into 2.1 and so it will go into 2.2 since we missed string freeze by a few
> > days. If this change doesn't get into 2.1 can we please stick with one
> > notification and no scrolling when music player is on a 320x480 device (how
> > we previously had it). Thanks
> 
> Confirming on behalf of IxD - Thanks Amy!
> 
> Also, flagging Axel and Delphine as this does seem like a string change.
> Putting the two strings side by side creates the possibility of
> concatenation errors, which we'd obviously like to avoid. 
> 
> Please review the attachment "Lockscreen_edits_320x480.png" and let us know
> if the "Emergency calls only" and "(no SIM)" strings can be moved to the
> same line. Putting them on the same line will allow us to have two
> notifications on the lock screen during music playback instead of just one.
> 
> Also flagging Amy to confirm the accuracy of my statements.

Thanks Rob, yes that's correct. We can fit 2 notifications and add back scrolling if we can move (no sim) to the line above.
Flags: needinfo?(amlee)
Amy, forgot to NI you on comment 27: we can't fit some locale's strings in one line as proposed by you.
Flags: needinfo?(amlee)
(In reply to John Lu [:mnjul] [MoCoTPE] from comment #29)
> Amy, forgot to NI you on comment 27: we can't fit some locale's strings in
> one line as proposed by you.

Hi John, 

Thanks for flagging me on this. If we can't fit it on two lines then we might have to revert back to one notification on 320x480 screens when music player is on. Flagging Rob for input as well on comment 27.
Flags: needinfo?(amlee)
Hi Rob, see above comment.
Flags: needinfo?(rmacdonald)
(In reply to Amy Lee [:amylee] from comment #30)

> Thanks for flagging me on this. If we can't fit it on two lines then we
> might have to revert back to one notification on 320x480 screens when music
> player is on. Flagging Rob for input as well on comment 27.

If we're only showing a single notification in this scenario (320x480 / no sim), I would propose that it not be scrollable as it's almost impossible to scroll a single item. Instead, each new notification would have to replace the previous one. Is this feasible at this stage?
Flags: needinfo?(rmacdonald)
(In reply to Rob MacDonald [:robmac] from comment #32)
> If we're only showing a single notification in this scenario (320x480 / no
> sim), I would propose that it not be scrollable as it's almost impossible to
> scroll a single item. Instead, each new notification would have to replace
> the previous one. Is this feasible at this stage?

Rob -- yes but may be not so 100% yes for you.

The single-item-no-scrollable behavior is current (on master) with 320x480 & music widget. Regarding your proposal, it is much more feasible that we keep such behavior both for two-line "Emergency Call" "(No Sim)" status, and for also one-line "Carrier" status.

It would be harder to implement if we want such behavior only for two-line "Emergency Call" "(No Sim)" status, and use two-item-scrollable behavior for one-line "Carrier" status. (Again, for 320x480 & music widget).

So I'm going to double make sure what you want: With the 320x480 & music widget scenario, is it "keep the behavior with both two-line and one-line statuses", or "use different behaviors with two-line and one-line statuses"? 

Please see screenshots attachment 8489196 [details] for how one-item-no-scrollable would look with one-line status, and attachment 8489196 [details] for how it would look with two-line status. Patch in attachment 8482119 [details] [review] has been modified to implement the "keep the behavior with both statuses" as it's easier to implement.

Thanks!
Flags: needinfo?(rmacdonald)
Target Milestone: 2.1 S4 (12sep) → 2.1 S5 (26sep)
Hi John...

I guess what I'm trying to say is, in scenarios where there is only space for a single notification, scrolling should be disabled as it's extremely difficult to scroll to subsequent notifications without the vertical space. Any time there is space to display two or more notifications, scrolling should be enabled.

Does that help clarify things? Also NI'ing Amy for any visual feedback. 

Rob
Flags: needinfo?(rmacdonald) → needinfo?(amlee)
Attached image Lockscreen_No_Sim.png
Hi John, 

I've attached a spec for the notification position when the "no SIM" message is present and music player is on. 

Otherwise, everything else remains the same since we had worked on the positioning before. The "just now" time stamp should be regular weight and not bold but I had already commented on this before so if it's already been fixed then please disregard.

Thanks
Flags: needinfo?(amlee)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Hi Amy,

Please have a check if the patch, just updated, meets your expectation as outlined in comment 37.

ps. The font-weight of the timestamp was fixed so a quick way to check if you're flashing the correct patch is to see if the timestamp is of normal weight.

Thanks!
Attachment #8482119 - Flags: ui-review?(rmacdonald) → ui-review?(amlee)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Hi John, 

Here's my feedback:

1. When I have music player on and I have one notification, I am able to highlight and open the notification. When a new notification replaces it, the notification is no longer actionable. Rob to confirm behaviour. 

The position of the notification when there is no sim and music player is on is correct now. Thanks!

Also flagging Rob for UI review.
Attachment #8482119 - Flags: ui-review?(rmacdonald)
Attachment #8482119 - Flags: ui-review?(amlee) → ui-review-
(In reply to Amy Lee [:amylee] from comment #39)
> 1. When I have music player on and I have one notification, I am able to
> highlight and open the notification. When a new notification replaces it,
> the notification is no longer actionable. Rob to confirm behaviour. 

Hi Amy, and Rob,

It turns out that the bug is also present on master too and I've informed Greg about it as he's more knowledgeable regarding actionable notifications. The bug is at bug 1069132.

So to clarify and to summarize, we have two separated-out bugs:
Bug 1058447 that Lockscreen with notifications is without the darken background just after device boot-up
Bug 1069132 that Newer notifications are not actionable when music player widget is on with 320x480 devices

However, the issues under the intended scope of the bug have been resolved/verified, right?

If so, I'd like to ask you, or Rob to kindly flag ui-reivew+ on this bug. Thanks!
Flags: needinfo?(rmacdonald)
Flags: needinfo?(amlee)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

+ UI review for the position of the notification on a 320x480 screen when music player is on with no sim. Thanks!
Attachment #8482119 - Flags: ui-review- → ui-review+
Flags: needinfo?(amlee)
Flags: needinfo?(rmacdonald)
Thanks Amy! I'll get the engineering aspects (writing code tests, etc) done and have the codes reviewed asap.
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

I'm unable to preview it on a 320x480 device so will defer to Amy, who has already +'d the patch. Thanks!
Attachment #8482119 - Flags: ui-review?(rmacdonald)
Note: I mis-merged the patch just five minutes ago, without actually getting the patch reviewed. It has been backed-out three minutes ago...
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

Hi Greg, could you review this patch? Thanks.
Attachment #8482119 - Flags: review?(gweng)
Comment on attachment 8482119 [details] [review]
Patch (PR @ GitHub)

I think there are some issues of the patch. Please discuss with me or fix them, thanks.
Attachment #8482119 - Flags: review?(gweng)
Attachment #8482119 - Flags: feedback+
Alright, please review the revised patch. Thanks!
Attachment #8493022 - Flags: review?(gweng)
Whiteboard: ux-tracking, visual design, jian [p=1] → ux-tracking, visual design, jian [p=2]
Comment on attachment 8493022 [details] [review]
Refactored patch (PR @ GitHub)

Some nits. Great work, thanks.
Attachment #8493022 - Flags: review?(gweng) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Hi John, 

Can you set approval-gaia-v2.1? on this patch? Thanks
Flags: needinfo?(jlu)
Comment on attachment 8493022 [details] [review]
Refactored patch (PR @ GitHub)

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): After bug 1038723, we have more room in lockscreen notifications container, so this bug adds that notification. This is for better UX.

[User impact] if declined: Not very much -- just non-optimal UX; functionality is not broken

[Testing completed]: Yes, TBPL; this patch has been living in master for quite a while without regression reported.

[Risk to taking this patch] (and alternatives if risky): Very little -- this patch only deals with some UX. Javascript codes out there are logics to determine whether and where the appropriate place a CSS class is to be added.

[String changes made]: None
(p.s. originally discussed string changes did not make into patch)
Attachment #8493022 - Flags: approval-gaia-v2.1?
Flags: needinfo?(jlu)
Comment on attachment 8493022 [details] [review]
Refactored patch (PR @ GitHub)

not bad enough
Attachment #8493022 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1-
This issue is verified fixed on Flame 2.2:

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

3 notifications can fit on lockscreen with music player.
---------------------------
Leaving verifyme keyword for 2.1.

---------------------------
Bug 1058447 and Bug 1069132 are verified fixed.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Removing verifyme per Comment 53
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.