Closed Bug 1060588 Opened 5 years ago Closed 5 years ago

DrawTarget version of ClipToRegionInternal is suboptimal for rectangles

Categories

(Core :: Graphics, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
firefox34 + fixed
firefox35 --- fixed

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Details

Attachments

(1 file)

When using the DrawTarget version of ClipToRegionInternal we will always create a full path and do a complex clip, even if the region consists of a single rectangle. That's a waste.
Assignee: nobody → bas
Status: NEW → ASSIGNED
Attachment #8481683 - Flags: review?(jmuizelaar)
Attachment #8481683 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/7861be6bf039
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment on attachment 8481683 [details] [diff] [review]
Use PushClipRect when possible

Approval Request Comment
[Feature/regressing bug #]: OMTC
[User impact if declined]: High CPU usage and poor performance reported in bug 1082929
[Describe test coverage new/current, TBPL]: Nightly & Aurota testing
[Risks and why]: Very low, well tested and simple fast-path added.
[String/UUID change made/needed]: None
Attachment #8481683 - Flags: approval-mozilla-beta?
Comment on attachment 8481683 [details] [diff] [review]
Use PushClipRect when possible

Beta+
(In reply to Bas Schouten (:bas.schouten) from comment #3)
> [User impact if declined]: High CPU usage and poor performance reported in
> bug 1082929

Does this patch fix bug 1082929?
Flags: needinfo?(bas)
Attachment #8481683 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Lawrence Mandel [:lmandel] from comment #4)
> Comment on attachment 8481683 [details] [diff] [review]
> Use PushClipRect when possible
> 
> Beta+
> (In reply to Bas Schouten (:bas.schouten) from comment #3)
> > [User impact if declined]: High CPU usage and poor performance reported in
> > bug 1082929
> 
> Does this patch fix bug 1082929?

Reportedly it does.
Flags: needinfo?(bas)
You need to log in before you can comment on or make changes to this bug.