1060618 - [titanic] Bounds Limiting: Don't backfill if too many builds or revisions to be done

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Gautam Akiwate [:gakiwate]]

Titanic (https://github.com/gakiwate/titanic/) is a tool to bisect test failures.

Titanic takes revision under investigation - which can be supplied to it using the APIs or command line and then works by pulling data about the revision and revisions before it from TBPL(https://tbpl.mozilla.org/) to bisect the failure.

The API runAnalysis returns two lists. One a list of revision that need to be analyzed. And the second the list of revisions that need to be built before analyzing. However, we would like to update the status to 'bounds-error' if the number of builds to be made are >5 or number of revisions to be analyzed are >10.

Most of the work will be centered around https://github.com/gakiwate/titanic/blob/master/backfill.py#L29 In addition to this you might have modify the return value of the function as you may seem fit and handle it accordingly.

Comment 1

[gokul.uf]

I'd like to take this up!

Comment 2

[Gautam Akiwate [:gakiwate]]

The bug is yours! :)

Comment 3

[gokul.uf]

added the fix and sent you a pull request :)

Comment 4

[Gautam Akiwate [:gakiwate]]

Can you base it off the patch on this BUG? https://bugzilla.mozilla.org/show_bug.cgi?id=1060589

Sorry. But that patch came in before you and it changes how you will do this BUG. Apologies for the same.

Comment 5

[gokul.uf]

No probs, can you merge it so that i can work on the latest code?

Comment 6

[Gautam Akiwate [:gakiwate]]

Done.

Comment 7

[gokul.uf]

Changed it and sent a merge request, please verify :)

Comment 8

[Gautam Akiwate [:gakiwate]]

Gave some feedback on the pull request.

Comment 9

[Gautam Akiwate [:gakiwate]]

Great work! :)

https://github.com/gakiwate/titanic/pull/10

Looking forward to more contributions from you! :)