Closed Bug 1060664 Opened 9 years ago Closed 9 years ago

Improve Fennec's Assert library.

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 35

People

(Reporter: ckitching, Assigned: ckitching)

References

Details

Attachments

(1 file, 1 obsolete file)

V2: Prettier assertions - now with more qref.
3.71 KB, patch
snorp
: review+
Details | Diff | Splinter Review
Attached patch Prettier assertions. (obsolete) — — Splinter Review 
So we've got this rather nifty Assert class, but it has three main problems:

1) It's almost never used.

2) It's not stripped by the optimiser (though that's a trivial Proguard config tweak I'll submit soonish over in Bug 1001713)

3) It's API could be more fluent. (I'd like to be able to write Assert.isNull(o) instead of Assert.isTrue(o != null), and suchlike).

Since I'm using it for my overlays work, I fixed 3. Here's a patch.
Attachment #8481652 - Flags: review?(snorp)

        Attachment #8481652 -
        Attachment is obsolete: true

        Attachment #8481652 -
        Flags: review?(snorp)

        Attachment #8481654 -
        Flags: review?(snorp)

    
  
See Also:  → 1044794

        Attachment #8481654 -
        Flags: review?(snorp) → review+

    
    

    
  
Since someone appears to have broken my ability to push...
Whiteboard: checkin-needed

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/31f9bba23ae0
Whiteboard: checkin-needed → checkin-needed[fixed-in-fx-team]
Whiteboard: checkin-needed[fixed-in-fx-team] → [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/31f9bba23ae0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.