1060685 - [tiles] new tab page legal text translations pl-PL

Status: RESOLVED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: newTab_pl.properties

Hello, bug 1058971 was filed to provide translations for a few text properties on the New Tab page of the Firefox Desktop which could be considered 'legal text'.  I'm attaching the translations they provided for your team to review.  The translation service used would appreciate testing and is happy to take your feedback if you feel this text does not convey the correct Mozilla voice.  Ultimately this is your module and your translations but we requested these translations to assist your efforts.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: newTab_pl.dtd

Comment 2

[Stefan Plewako [:stef]]

The whole thing looks like a bad joke to me but anyway, here is a diff with comments between attached files and l10n-central/pl 

The whole file had file endings changed (to Windows) - that alone would give r-

--- browser/chrome/browser/newTab.dtd	2014-08-24 15:44:31.000000000 +0200
+++ /Users/splewako/Downloads/newTab.dtd	2014-08-31 18:16:09.000000000 +0200
@@ -1,13 +1,16 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
+<!-- These strings are used in the about:newtab page -->

We do not use comments, adding them in the whole file is would give r- right away.

 <!ENTITY newtab.pageTitle "Nowa karta">
-<!ENTITY newtab.customize.title "Dostosuj stronę nowej karty">
+<!ENTITY newtab.customize.title "Dostosuj stronę Nowa karta">

Although acceptable, original version is more natural and I don't see a reason for such change.

 <!ENTITY newtab.customize.enhanced "Rozszerzona">
 <!ENTITY newtab.customize.classic "Klasyczna">
 <!ENTITY newtab.customize.blank "Pusta">
+<!ENTITY newtab.customize.what "Co to za strona?">
+<!ENTITY newtab.intro.header "Co to za strona?">
 <!ENTITY newtab.undo.removedLabel "Miniaturka usunięta.">
 <!ENTITY newtab.undo.undoButton "Cofnij.">
 <!ENTITY newtab.undo.restoreButton "Przywróć wszystkie.">
 <!ENTITY newtab.undo.closeTooltip "Ukryj">
--- browser/chrome/browser/newTab.properties	2014-08-24 16:02:22.000000000 +0200
+++ /Users/splewako/Downloads/newTab.properties	2014-08-31 18:15:53.000000000 +0200
@@ -4,8 +4,27 @@
 
 newtab.pin=Przypnij tę stronę w jej obecnym miejscu
 newtab.unpin=Odepnij tę stronę
 newtab.block=Usuń tę stronę
-newtab.sponsored.button=Sponsorowana
-newtab.sponsored.explain=Ta miniaturka jest wyświetlana w imieniu partnera Mozilli. Miniaturkę można usunąć używając przycisku %1$S. %2$S
-newtab.enhanced.explain=Partner Mozilli zmienił wygląd tej miniaturki. Modyfikowanie miniaturek można wyłączyć korzystając z przycisku %1$S. %2$S
-newtab.learn.link=Dowiedz się więcej…
+# LOCALIZATION NOTE(newtab.sponsored.button): This text appears for sponsored
+# and enhanced tiles on the same line as the tile's title, so prefer short
+# strings to avoid overlap. This string should be uppercase.
+newtab.sponsored.button=SPONSOROWANE

This is simply way off and wrong even ignoring uppercase aspect.

+# LOCALIZATION NOTE(newtab.sponsored.explain): %1$S will be replaced inline by
+# the (X) block icon. %2$S will be replaced by an active link using string
+# newtab.learn.link as text.
+newtab.sponsored.explain=Ta miniaturka jest wyświetlana w imieniu partnera Mozilli. Możesz ją w każdej chwili usunąć, korzystając z przycisku %1$S. %2$S

Acceptable, more direct and longer - I don't see a reason for such change.

+# LOCALIZATION NOTE(newtab.enhanced.explain): %1$S will be replaced inline by
+# the gear icon used to customize the new tab window. %2$S will be replaced by
+# an active link using string newtab.learn.link as text.
+newtab.enhanced.explain=Partner Mozilli zmienił wygląd tej miniaturki. Modyfikowanie miniaturek, możesz wyłączyć, korzystając z przycisku %1$S. %2$S

Acceptable, more direct and longer - I don't see a reason for such change.

+# LOCALIZATION NOTE(newtab.intro.paragraph1): %1$S will be replaced inline by
+# active link using string newtab.learn.link as text.
+newtab.intro.paragraph1=Gdy otworzysz nową kartę, zobaczysz miniaturki z witryn, które często odwiedzasz, a także miniaturki, które naszym zdaniem mogą Cię zainteresować. Niektóre z nich mogą być sponsorowane przez partnerów Mozilli. Zawsze pokazujemy, które miniaturki są sponsorowane. %1$S

+W nowych kartach, wyświetlane są miniaturki często odwiedzanych stron oraz miniaturki, które naszym zdaniem mogą być dla Ciebie interesujące. Niektóre z nich mogą być sponsorowane przez partnerów Mozilli i zawsze będą stosownie oznaczane. %1$S

+# LOCALIZATION NOTE(newtab.intro.paragraph2): %1$S will be replaced inline by
+# active link using string newtab.privacy.link as text.
+newtab.intro.paragraph2=Aby umożliwić udostępnianie tej usługi, Mozilla zbiera i wykorzystuje pewne dane analityczne związane ze sposobem, w jaki korzystasz z kafelków. Dane te są użytkowane zgodnie z naszą %1$S.

+Aby udostępniać tę funkcję, Mozilla zbiera i wykorzystuje pewne informacje o sposobie wykorzystywania miniaturek, zgodnie z %1$S.

+# LOCALIZATION NOTE(newtab.intro.paragraph3): %1$S will be replaced inline by
+# the gear icon used to customize the new tab window.
+newtab.intro.paragraph3=Możesz wyłączyć funkcję miniaturek, korzystając z przycisku %1$S.

+Wyświetlanie miniaturek można wyłączyć korzystając z przycisku %1$S.

+newtab.learn.link=Więcej informacji…
+newtab.privacy.link=polityką prywatności



https://hg.mozilla.org/l10n-central/pl/rev/43f36054222c

Comment 3

[Ed Lee :Mardak]

(In reply to Stefan Plewako [:stef] from comment #2)
>  <!ENTITY newtab.pageTitle "Nowa karta">
> -<!ENTITY newtab.customize.title "Dostosuj stronę nowej karty">
> +<!ENTITY newtab.customize.title "Dostosuj stronę Nowa karta">
> Although acceptable, original version is more natural and I don't see a
> reason for such change.
Thanks for reviewing the strings. How should I read your comments (this and others)? You seem to have generated a diff output. Were you just seeing which of the attached strings were different?

The checked in file is with the lowercase "nowej karty":
https://hg.mozilla.org/l10n-central/pl/file/tip/browser/chrome/browser/newTab.dtd#l6

> +newtab.sponsored.button=SPONSOROWANE
> This is simply way off and wrong even ignoring uppercase aspect.
Are you saying the text cannot be uppercase? I believe there's a requirement of showing the sponsored label/button in a certain way.

Comment 4

[Stefan Plewako [:stef]]

(In reply to Ed Lee :Mardak from comment #3)
> Thanks for reviewing the strings. How should I read your comments (this and
> others)? You seem to have generated a diff output. Were you just seeing
> which of the attached strings were different?

Yes, first I generated diff output against what was already in repository because I don't see a reason to ignore things translated earlier - this way it is also immediately obvious what is proposed. Then I added comments (lines without +/-). In three cases I also provided slightly different form that was later checked in.

> > +newtab.sponsored.button=SPONSOROWANE
> > This is simply way off and wrong even ignoring uppercase aspect.
> Are you saying the text cannot be uppercase? I believe there's a requirement
> of showing the sponsored label/button in a certain way.

I didn't say that. If there is requirement of showing sponsored label in a certain way there should be explicit info about it. If this is design decision it probably should be implemented in css first (i.e. text-transform or font-variant-caps).

Comment 5

[Ed Lee :Mardak]

(In reply to Stefan Plewako [:stef] from comment #4)
> If there is requirement of showing sponsored label in a certain way
Where should that information be put? I asked about the upper case because I'm not sure if "Sponsorowana" vs "SPONSOROWANA" mean different things. We were told not to use text-transform because of that (e.g., in Irish, ÁR NATHAIR = OUR SNAKE and ÁR nATHAIR = OUR FATHER).

Comment 6

[Ed Lee :Mardak]

Attachment: comment 2 screenshot

Thanks for translating the strings appropriately. Here's how things look on aurora for the newtab page except for one of the sponsored label I made it uppercase just to test how it looks.

Comment 7

[Stefan Plewako [:stef]]

(In reply to Ed Lee :Mardak from comment #5)
> (In reply to Stefan Plewako [:stef] from comment #4)
> > If there is requirement of showing sponsored label in a certain way
> Where should that information be put? I asked about the upper case because
> I'm not sure if "Sponsorowana" vs "SPONSOROWANA" mean different things. We
> were told not to use text-transform because of that (e.g., in Irish, ÁR
> NATHAIR = OUR SNAKE and ÁR nATHAIR = OUR FATHER).

"Sponsorowana" vs "SPONSOROWANA" mean the same in Polish and although "only first letter uppercase" version looks good to me I will update the label soon (so it could smoothly land in aurora for 34) hoping that the requested info will be added/provided later.

Information that this is an actual requirement, not enforced in other ways because it could mean something else in some languages and a link to the discussion/decision/bug in l10n comment would be probably much better then the current wording.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

All uppercase words in polish look really bad and is basically never used in any good UI. I agree with Stefan here that unless we really must violate this principle, having first letter uppercase is totally enough to indicate the importance of the label (because we usually don't uppercase even the first letter unless it is a beginnign of a sentence).

Comment 9

[Stefan Plewako [:stef]]

https://hg.mozilla.org/l10n-central/pl/rev/1f14093cd78c

I'm reopening the bug to track requested in comment 7 info addition - if that will not happen (in Aurora 34 cycle) I will assume that there is no such requirement and revert it back.

Comment 10

[Ed Lee :Mardak]

clarkbw, who can provide guidance on the uppercase-ness of SPONSORED for localized sponsored indicator? See comment 7

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Ed Lee :Mardak from comment #10)
> clarkbw, who can provide guidance on the uppercase-ness of SPONSORED for
> localized sponsored indicator? See comment 7

I'd let Aaron make the call.

Aaron, for localizations where the uppercase of SPONSORED is out of place I'm guessing you want the localizers to make the judgement call?

Comment 12

[Aaron]

Correct, Bryan - the localizers should make any adjustments they feel necessary. 

Please invite them to share with us their decisions so that we can start learning about these contextual differences, which can inform our thinking in the future regarding how we handle labels, tags, etc.

Comment 13

[Ed Lee :Mardak]

stef, sorry for the back and forth! You were right in landing the string originally as "Sponsorowana"

Comment 14

[Stefan Plewako [:stef]]

No problem, glad this has been sorted out, reverting to "Sponsorowana",
https://hg.mozilla.org/l10n-central/pl/rev/f73f5a3d32ca