1060693 - SHB shows up when opening a game

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

On Flame device with current trunk.
Open games smart collection.
Click for example on simon says.

Software Home Button shows up for a few seconds even when its disabled.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Eli, can you take a look here?

Comment 2

[Etienne Segonzac (:etienne)]

got a fix, stealing

Comment 3

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Comment 4

[Etienne Segonzac (:etienne)]

For wrapper, e.me stuff and all, the isFullScreen() appWindow method returns |undefined| since we have no manifest.

But now we're using this result to do a classList.toggle('', bool), and since the second param is undefined we actually display the SHB once out of twice :)

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8482165 [details] [review]
Gaia PR

Not sure if we have better way to replace the long statement to generate the boolean..but r+ still.

Comment 6

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/7b35a2079626fbc2aa1e4371d0a2af73fea19253

Comment 7

[Adam Alldredge [:AdamA][Inactive]]

The issue is verified fixed in Flame 2.1 and Flame 2.2:

Flame 2.1 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141008000201
Gaia: d71f8804d7229f4b354259d5d8543c25b4796064
Gecko: 7fa82c9acdf2
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141008040203
Gaia: 0bc74ce502672cf0265b24cf3a25d117c3de5e71
Gecko: e4cfacb76830
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The SHB did not appear when opening a game while it was disabled.