1060723 - Call info page isn't updated after a call dispatched from it ends

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

STR:
1) Open call info page for any number or contact.
2) Place a call from a phone number on this page.
3) Wait any amount of time and then end the call.

Expected: The call appears in the call list.
Actual: The call does not appear in the call list.

Comment 1

[Anthony Ricaud (:rik)]

We could fix this by calling CallInfo.show() when we receive a visibilitychange event. And remove the visibilitychange listener when we close the view.

Comment 2

[Doug Sherk (:drs) (inactive)]

We discussed in sprint planning that the best way to fix this is to listen to indexedDB events and recreate/update the view when the transaction is complete.

Gabriele says that there's no actual event for this. We'll come back to it once we have a real solution.

Comment 3

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/23813

Comment 4

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8485826 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23813

I really like the idea of using a custom DOM event here for communication as it's a nice and clean shortcut, and is reminiscent of the WC approach. Unfortunately, I don't agree with the specific pattern used, and there are a few more relatively minor nits I left comments for on the PR.

Comment 5

[Anthony Ricaud (:rik)]

Comment on attachment 8485826 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23813

I haven't addressed most of the comments but explained my reasons not to do so.

Comment 6

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8485826 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23813

Thanks for the explanations, and sorry for my mistake with the DOM event suggestion. I left a couple of comments, only one of which I think matters.

Comment 7

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/35a6d80022079905b8fd7bd05f062cd44efeca95