1060825 - Standalone Loop client have French translations missing

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect)

Description

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Screen Shot 2014-08-30 at 19.00.35.png

Trying to make a self-call using latest Nightly (2014-08-30), the standalone link-clicker page doesn't show up translated texts anymore (see attached screenshot). The issue is currently reproducible indefinitely, even with a full cache purge & using private browsing.

Interestingly enough, it works fine using Chrome.

Note that I'm using a very ****/slow connection at this moment. I'm suspecting a possible race condition as it seems the strings aren't yet loaded when the UI tries to render elements with them (see the l10n warnings in the console).

Comment 1

[Maire Reavy [:mreavy]]

Niko -- How can I confirm this?   Should I change my language setting  to non-English in the link-clicker browser?  FYI: It appears to work fine when my browser is set to my default language (English).

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Excerpt from IRC:

[22:09:16]  mreavy:	 [19:23:49] NiKo`: do I need to change my language setting?
[22:14:06]  NiKo`:	 mreavy: indeed, it works fine with English, while it breaks with French
[22:14:29]  NiKo`:	 mreavy: just open preferences > content and and & move up French as a prefered language
[22:14:51]  NiKo`:	 (there might be some addons to tweak http requests headers but it's probably overkill here)
[22:21:42]  NiKo`:	 hmm webl10n uses navigator.language which returns fr-FR atm, I *think* I've seen it returning simply "fr" at some point in the past
[22:22:15]  NiKo`:	 oh. https://bugzilla.mozilla.org/show_bug.cgi?id=1052339
[22:22:20]  NiKo`:	 interesting.
[22:22:21]  firebot:	 Bug 1052339 — NEW — Sandalone client relies on navigator.language for selecting locale, which Google Chrome may return u
[22:24:04]  NiKo`:	 hmm I don't think it's related, switching to use simply "fr" doesn't fix the issue
[22:25:42]  NiKo`:	 issue is reproducible with stable, beta and nightly

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Reproduced as well with a fresh profile without any supplementary addon installed.

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Damn, that's because for some reason, some French translations for the new UI are missing in latest master https://github.com/mozilla/gecko-dev/blob/master/browser/components/loop/standalone/content/l10n/data.ini

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Added missing French translations for Loop standalone client.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

There are two different bugs being described here.  One of them is that if all the strings for a given locale aren't available, it falls back to "no strings" (which is always wrong) rather than "en-US" or some other better fallback.  That probably wants a spin-off bug.

Comment 7

[Mark Banner (:standard8)]

(In reply to Dan Mosedale (:dmose) - not reading bugmail; needinfo? for response from comment #6)
> There are two different bugs being described here.  One of them is that if
> all the strings for a given locale aren't available, it falls back to "no
> strings" (which is always wrong) rather than "en-US" or some other better
> fallback.  That probably wants a spin-off bug.

Broken out to bug 1062771

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8481854 [details] [diff] [review]
Added missing French translations for Loop standalone client.

Now strings have stabilised, I suggest we either drop the Fr translations, or just re-update from scratch.

Comment 9

[Mark Banner (:standard8)]

Wontfix in favour of bug 1000269