1060837 - browser_canvas-frontend-stepping.js leaks 2 windows until shutdown when run in a standalone directory

Status: RESOLVED FIXED

(DevTools Graveyard :: Canvas Debugger, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

In bug 992911 we are working towards running the browser-chrome tests as single directories instead of larger chunks, this results in some failures.

https://tbpl.mozilla.org/?tree=Try&rev=67533dfe9869

TEST-UNEXPECTED-FAIL | browser/devtools/canvasdebugger/test/browser_canvas-frontend-stepping.js | leaked 1 window(s) until shutdown [url = about:blank]
TEST-UNEXPECTED-FAIL | browser/devtools/canvasdebugger/test/browser_canvas-frontend-stepping.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1060837-Properly-destroy-toolbox-when-removing-t.patch

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8481829 [details] [diff] [review]
0001-Bug-1060837-Properly-destroy-toolbox-when-removing-t.patch

Review of attachment 8481829 [details] [diff] [review]:
-----------------------------------------------------------------

If I'm reading the patch correctly, we need to wait for the toolbox to finish closing before the test finishes. 

There's no guarantee there's an actual toolbox available when removeTab is called (there are tests with multiple tabs, and furthermore, this exact same logic for removeTab is used in almost all devtools head.js files, not just for the canvasdebugger, so the problem seems to be a bit more generic and should affect other tools as well), please make the `teardown` function handle this better, instead of removeTab. Currently, it only waits for the active tool to be closed, not the whole toolbox.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8481829 [details] [diff] [review]
0001-Bug-1060837-Properly-destroy-toolbox-when-removing-t.patch

Let's fix that in bug 1060840.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Fixed by bug 1060840.