1060847 - Form history dropdown does not pop up by double click/up arrow key in search field of about:home/about:newtab

Status: NEW

(Firefox :: Search, defect, P4)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

Steps To Reproduce:
1. Open about:home and search from search filed
2. Repeat step2 several times

3. Open about:home, and double click/pres uparrow key

Actual Results:
Form history doropdown does not pop up

Expected Results:
Form history doropdown should pop up

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
https://hg.mozilla.org/mozilla-central/rev/6551323d96e6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140801134649
Bad:
https://hg.mozilla.org/mozilla-central/rev/eed9fe35a00d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140830030204
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6551323d96e6&tochange=eed9fe35a00d


Regression window(fx)
Good:
https://hg.mozilla.org/integration/fx-team/rev/f08fb8275e5b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140801112450
Bad:
https://hg.mozilla.org/integration/fx-team/rev/fe53a2b0e7d0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140801120154
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f08fb8275e5b&tochange=fe53a2b0e7d0

Regressed by: Bug 612453 and Bug 1028985

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Drew, like in bug 1060845, can you help?

Tracking because we are doing a lot on this topic in the 33 release and we want something clean.

Comment 3

[Drew Willcoxon :adw]

mmaslaney, should the form history popup on about:home/newtab be able to be opened by clicking or pressing the up key?

For reference, before search suggestions on these pages landed, you could single-click inside these inputs when they were focused to open the form history popup, and you could also press the up key to open it.  And in all versions of Firefox including 32 and Nightly, you can press the up key in the main chrome search bar to open its form history popup, but you can't click to open it as far as I can tell.

Comment 4

[Alice0775 White]

FYI, Double clicking the input filed of normal web page opens form history drop down.

Comment 5

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Opening the popup in these cases is the consistent thing, so let's do that.
It should, of course, only show results from history at that point until the user starts typing.
The triggers for the popup should be the same as for other form fields.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

We don't need to track this separately. We're going to consolidate the implementations individually, which will fix most of these behavior differences. Not a regression, and not major issues, so not tracking-worthy.

Comment 7

[Drew Willcoxon :adw]

Bug 1066787 is the consolidation mentioned in comment 6.

Comment 8

[Florian Quèze [:florian]]

What's the status of this bug?

Comment 9

[Drew Willcoxon :adw]

Comment 0 still happens.  It shouldn't be too hard to fix, if we want.  Note that bug 1171344 changed the implementation of about:home/newtab's search field since this bug was filed.