1060945 - Cannot disable a devtools panel if its visibilityswitch pref doesn't exist

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I have a couple of extensions installed that use the new sdk pane api, and I can no longer disable enable them with today's nightly. The error is:

System JS : ERROR resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox-options.js:55 - Error: Unknown type

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

( I also have the ember extension installed, and it can be enabled / disabled just fine )

Comment 2

[Brian Grinstead [:bgrins]]

I'm guessing that since tool.visibilityswitch is not a known pref (something like "devtools.foo.enabled") it is failing to set it.  The ember extension probably works because you had already installed it and toggled it, initializing the pref before this bug was introduced.  Most likely we just need to *not* call SetPref when a tool enable/disable checkbox is pressed, and instead just call Services.prefs.setBoolPref directly.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: disable-addon-panel.patch

Fixes issue, as described in Comment 2.  Try push: https://tbpl.mozilla.org/?tree=Try&rev=9b73f56730ad

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8484379 [details] [diff] [review]
disable-addon-panel.patch

Review of attachment 8484379 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
My only comment is that, while we're at it, we might as well change the test a little more to:
- add a comment at the top explaining what the test is supposed to be testing
- make use of asyncTest which exists in head.js in this directory to simplify a bit the test

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: disable-addon-panel-1.patch

Refactored test and added a comment at the top of it: https://tbpl.mozilla.org/?tree=Try&rev=a2bcf8f54b62

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c5ca9293fd67

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5ca9293fd67