1060959 - comm-central/configure: line 544: test: : integer expression expected

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Philip Chee]

https://bugzilla.mozilla.org/show_bug.cgi?id=1040009#c28

> >+if test "$MOZ_AUTOMATION" -eq 1; then
> This warns if $MOZ_AUTOMATION isn't an integer expression...

Comment 1

[Ian Neal]

Attachment: Change the test in configure.in

This seems to fix it for me.

Comment 2

[Philip Chee]

Comment on attachment 8481976 [details] [diff] [review]
Change the test in configure.in

f=me thanks.

Comment 3

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8481976 [details] [diff] [review]
Change the test in configure.in

Review of attachment 8481976 [details] [diff] [review]:
-----------------------------------------------------------------

The entire if statement should be deleted. It was a temporary workaround to avoid having to make too many coordinated checkins. Now that buildbot has been updated, it's not needed.

Comment 4

[Ian Neal]

Attachment: Remove the test [Checked in: Comment 5]

As suggested remove the entire if statement.

Comment 5

[Ian Neal]

Comment on attachment 8482440 [details] [diff] [review]
Remove the test [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/5540d3b4eb23

Comment 6

[Ian Neal]

Comment on attachment 8482440 [details] [diff] [review]
Remove the test [Checked in: Comment 5]

[Approval Request Comment]
Regression caused by (bug #): 1040009
User impact if declined: Warning when building locally
Testing completed (on c-c, etc.): Locally and now on c-c
Risk to taking this patch (and alternatives if risky): none

Comment 7

[Philip Chee]

(In reply to Joshua Cranmer [:jcranmer] from comment #3)

> The entire if statement should be deleted. It was a temporary workaround to
> avoid having to make too many coordinated checkins. Now that buildbot has
> been updated, it's not needed.

Yes but have the *SeaMonkey* buildbots been updated? Thunderbird uses the Firefox infra but not SeaMonkey