Closed Bug 1060973 Opened 5 years ago Closed 5 years ago

Fix more bad implicit constructors in XPCOM

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan.akhgari
Blocks: explicit
Attachment #8481987 - Flags: review?(nfroyd)
Comment on attachment 8481987 [details] [diff] [review]
Fix more bad implicit constructors in XPCOM

Review of attachment 8481987 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/pldhash.h
@@ +278,5 @@
>     * builds, attempting to do so will result in an assertion failure.
>     */
>    class Iterator {
>    public:
> +    explicit Iterator(const PLDHashTable* aTable);

Argh, I should have caught this.
Attachment #8481987 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd (:froydnj) from comment #2)
> Argh, I should have caught this.

Don't feel bad, checking tedious things like this is what static analysis is for.
https://hg.mozilla.org/mozilla-central/rev/d42caa7bcaca
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.