Closed Bug 1061032 Opened 5 years ago Closed 5 years ago

crash in java.lang.NullPointerException: at org.mozilla.gecko.ChromeCast$2.onConnected(ChromeCast.java)

Categories

(Firefox for Android :: Screencasting, defect, critical)

34 Branch
All
Android
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 35
Tracking Status
firefox33 --- wontfix
firefox34 + verified
firefox35 --- verified
fennec 33+ ---

People

(Reporter: aaronmt, Assigned: wesj)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

This bug was filed from the Socorro interface and is 
report bp-3b539201-693c-4048-9780-c56032140830.
=============================================================

java.lang.NullPointerException
	at org.mozilla.gecko.ChromeCast$2.onConnected(ChromeCast.java:196)
	at com.google.android.gms.internal.hd.c(Unknown Source)
	at com.google.android.gms.common.api.c.eF(Unknown Source)
	at com.google.android.gms.common.api.c.d(Unknown Source)
	at com.google.android.gms.common.api.c$2.onConnected(Unknown Source)
	at com.google.android.gms.internal.hd.c(Unknown Source)
	at com.google.android.gms.internal.hd.ck(Unknown Source)
	at com.google.android.gms.internal.hc$h.b(Unknown Source)
	at com.google.android.gms.internal.hc$h.d(Unknown Source)
	at com.google.android.gms.internal.hc$b.fq(Unknown Source)
	at com.google.android.gms.internal.hc$a.handleMessage(Unknown Source)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:146)
	at android.app.ActivityThread.main(ActivityThread.java:5487)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1283)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1099)
	at dalvik.system.NativeStart.main(Native Method)
tracking-fennec: ? → 33+
Blocks: 901803
Do we still see this?
Flags: needinfo?(kbrosnan)
Yes, 1 crash each on B6 and B7.
Flags: needinfo?(kbrosnan)
Attached file chromecast3 (obsolete) —
Attached patch PatchSplinter Review
At first glance this looks impossible. I have to guess that sometime between when we call api.connect() and the onConnected callback is called, someone calls stop? That's the only place we set the apiClient to null (but note, stop has an apiClient.isConnected() call in it that would have to pass first). Maybe something reconnects automatically for us at some point after stop fires and that causes this to refire? I
Attachment #8499045 - Attachment description: chromecast3 → Patch
Attachment #8499045 - Attachment is patch: true
Attachment #8499045 - Flags: review?(mark.finkle)
Attachment #8499041 - Attachment is obsolete: true
Attachment #8499045 - Flags: review?(mark.finkle) → review+
Comment on attachment 8499045 [details] [diff] [review]
Patch

I realize that I missed the last beta here (I think?). Noming anyway because this is tracking. If we don't care about beta, someone should decide and remove it.

Approval Request Comment
[Feature/regressing bug #]: Chromecast stuff
[User impact if declined]: Possible crash somehow? We don't have str.
[Describe test coverage new/current, TBPL]: None. Can't test Chromecast stuff very well
[Risks and why]: Low risk. Just a null check
[String/UUID change made/needed]: none.
Attachment #8499045 - Flags: approval-mozilla-beta?
Attachment #8499045 - Flags: approval-mozilla-aurora?
Comment on attachment 8499045 [details] [diff] [review]
Patch

It's too late for 33 as we have already built the release candidate. Let's take the fix in 34 once it's landed on m-c.
Attachment #8499045 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
https://hg.mozilla.org/mozilla-central/rev/a259ef6f66d5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8499045 [details] [diff] [review]
Patch

Sadly, we've been burned when adding a simple NPE check in Fennec before. We're early enough in the cycle that I think we can take this check. Do we have chromecasts that we can use to actually test this case?

Aurora+
Attachment #8499045 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(wjohnston)
We have plenty. We just don't have any STR for these bugs.
Flags: needinfo?(wjohnston)
Calling this verified fixed since there are 0 crash reports in Socorro for this in 34/35 over the last week. Additionally, I'm marking this qe-verify- since we don't have STR for QE to verify.
Status: RESOLVED → VERIFIED
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.