Closed Bug 1061085 Opened 9 years ago Closed 9 years ago

Clean up misused export macros from bug 1041886

Categories

(Core :: Security, defect)

Product:
Core
Component:
Security
Version:
34 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox33 --- unaffected
firefox34 --- fixed
firefox35 --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: jld, Assigned: jld)

Details

Attachments

(1 file)

bug1061085-more-moz-export-hg0.diff
1.18 KB, patch
glandium
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Bug 1059602 took care of the misused MFBT_API in security/sandbox/linux/SandboxInternal.h (introduced in bug 1041886), but there are more in Sandbox.h.

As long at at least one symbol exported from libmozsandbox and used in libxul exists then bug 1059602 shouldn't reoccur, but that's no excuse not to clean it up now.
Attachment #8482108 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f75925c6b161
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment on attachment 8482108 [details] [diff] [review]
bug1061085-more-moz-export-hg0.diff

Approval Request Comment
[Feature/regressing bug #]: Bug 1041886
[User impact if declined]: Possibly nothing, but the code currently on the 34 branch is incorrect and could cause problems later if future changes are uplifted.
[Describe test coverage new/current, TBPL]: Covered by build testing.
[Risks and why]: None; if it passes try then it works. 
[String/UUID change made/needed]: None.
Attachment #8482108 - Flags: approval-mozilla-aurora?
Attachment #8482108 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.