1061088 - [Lockscreen] The time of the second notification overlaps with the time of the first notification when generating multiple notifications and taping the second one

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Gerry Chang [:gchang]]

### Steps:
1. Generate multiple notifications in lockscreen. ex: make phone calls more than once.
2. Tap the second notification

### Expected:
1. The second notification should be selected. The background color should become darker.
2. The time should be changed to "open"

### Actual:
1. The second notification is not selected. But, the first notification is selected.
2. The time of the first notification "just now" become "open".
   The time of the second notification "just now" move up and overlap with the time of first notification "open".

### Reproduce rate
always

### Version:
Device    flame
Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1

Comment 1

[Gerry Chang [:gchang]]

[Blocking Requested - why for this release]:

Comment 2

[Gerry Chang [:gchang]]

Attachment: overlap.png

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

I've found this is caused by Bug 1038723 and it should be a regression. Because I reset --hard master to the patch, and it's still broken. After revert the patch from the master I reseted, it get fixed.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

I do reset rather than directly revert because I can't revert it without any conflict. Anyway, the build now is without this bug after the reseting & reverting.

After revert my master tree now is:

118-168-132-181.dynamic.hinet.net snowmantw:~/Projects/gaia$
118-168-132-181.dynamic.hinet.net snowmantw:~/Projects/gaia$ git log
commit 7ce28c1bfb2c11e15aeb4aae60772293909eaa18
Author: Greg Weng <[e-mail]>
Date:   Mon Sep 1 15:01:32 2014 +0800

    Revert "Merge pull request #23153 from gmarty/Bug-1038723-Utility-Tray-Visual-Refresh"

    This reverts commit be46e59bc351842fcda012f5b8f24b99cd70cc88, reversing
    changes made to c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df.

commit be46e59bc351842fcda012f5b8f24b99cd70cc88
Merge: c05ee27 6aa3b64
Author: Guillaume C. Marty <[e-mail]>
Date:   Fri Aug 29 19:01:26 2014 +0100

    Merge pull request #23153 from gmarty/Bug-1038723-Utility-Tray-Visual-Refresh

    Bug 1038723 - [Utility Tray] Visual Refresh

commit c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df
Merge: 01f3265 9543ba1
Author: Ben Francis <[e-mail]>
Date:   Fri Aug 29 18:57:24 2014 +0100

    Merge pull request #23440 from benfrancis/1058096

    Bug 1058096 - Add show windows button to Rocketbar on Browser start page r=kgrandon

commit 01f3265b74493d032f52cef8c5ed12810d9be78d

(...)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Correct regression flagging. 

Gerry? Is this considered a smoketest breakage? Should we simply backout this patch?

Comment 6

[Gerry Chang [:gchang]]

This test is not covered by smoketest. It belongs to 2.1 new feature. So, I would not say it's a smoketest breakage.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Fixed by backout, see bug 1038723 comment 37.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Gerry Chang [:cfchang] from comment #6)
> This test is not covered by smoketest. It belongs to 2.1 new feature. So, I
> would not say it's a smoketest breakage.

Notifications on lock screen is a feature since v1.0.1.

Jason, do we have any smoke tests about notifications on lock screen? Do you think it make sense to create one?

Comment 9

[Gerry Chang [:gchang]]

The touch action on notification is a new 2.1 feature. And, this bug will happen when user click the notification. So far, there is no test case covering the "touch-action" on notification.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Gerry Chang [:cfchang] from comment #9)
> The touch action on notification is a new 2.1 feature. And, this bug will
> happen when user click the notification. So far, there is no test case
> covering the "touch-action" on notification.

Right. Sorry for the confusion. So the right question to ask is "should this new feature be included in the smoketest?"

Comment 11

[Gerry Chang [:gchang]]

Verified @
Gaia      7e469783859785a8bd4bf02a802f32561c84be7b
Gecko     https://hg.mozilla.org/mozilla-central/rev/372ce1f36116
BuildID   20140902160202
Version   35.0a1

Comment 12

[Jason Smith [:jsmith]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #8)
> (In reply to Gerry Chang [:cfchang] from comment #6)
> > This test is not covered by smoketest. It belongs to 2.1 new feature. So, I
> > would not say it's a smoketest breakage.
> 
> Notifications on lock screen is a feature since v1.0.1.
> 
> Jason, do we have any smoke tests about notifications on lock screen? Do you
> think it make sense to create one?

Not right now. Marcia & I chatted about this - we both don't think we would include this as a smoketest mainly because we think lockscreen notifications breaking wouldn't be classified as bare bones functionality, since if it broke, then you could still use the basics of the phone.

Comment 13

[Gerry Chang [:gchang]]

Verified @
Gaia      90812662b9e0d3aba88882290c08971fdff98515
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/9da2a5828e56
BuildID   20140909160202
Version   34.0a2

Comment 14

[Tony Chung [:tchung]]

per comment 13, marking 2.1 branch verified.