1061127 - [Lockscreen] The time of notification in lockscreen keeps display "just now" as time elapsed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Gerry Chang [:gchang]]

### Steps:
1. Generate multiple notifications in lockscreen. ex: create multiple screenshots.
   In attachment, the screenshots were created in 4:24
2. Wait for more than 10 minutes. 
3. In 4:37, the time of the notifications are all "just now".

### Expected:
1. The time should be like "10m ago"


### Actual:
1. The time doesn't change.

### Reproduce rate
always

### Version:
Device    flame
Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1

Comment 1

[Gerry Chang [:gchang]]

[Blocking Requested - why for this release]:

Comment 2

[Gerry Chang [:gchang]]

Attachment: time keeps showing "just now"

Comment 3

[howie [:howie]]

Triage: blocker

Comment 4

[:gerard-majax]

That was working, until recently ... Let's get regression window.

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

Confirmed regression. Updating tracking flags from branch checking results on Flame.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

b2g inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140829112301
Gaia: c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df
Gecko: 7d956b954dd7
Version: 34.0a1
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140829113200
Gaia: 4419091ae760328a52606920e335331a16fcb448
Gecko: 3748d4065959
Version: 34.0a1
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken gecko & Last working gaia - issue does NOT repro
Gaia: c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df
Gecko: 3748d4065959

First broken gaia & Last working gecko - issue DOES repro
Gaia: 4419091ae760328a52606920e335331a16fcb448
Gecko: 7d956b954dd7

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df...4419091ae760328a52606920e335331a16fcb448

Possibly caused by Bug 1038723 ?

Comment 7

[Joshua Mitchell (Inactive)]

Possibly caused by Bug 1038723 ? can you take a look ?

Comment 8

[Guillaume Marty [:gmarty]]

This regression is caused by this line:
https://github.com/mozilla-b2g/gaia/pull/23572/files#diff-9a74bae315146783bc7b24d5d7302a95L331

Reverting the selector to its previous value will probably fix it.
This is something I discussed with Etienne, but I didn't know it would have an impact outside of the utility tray.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Set the regressed bug as blocked.

:gmarty, could you address the regression?

Comment 10

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Hey Tim, here is the fix that revert to the original behaviour.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8486429 [details] [review]
Github PR

I think this is a valid fix for v2.1 but I don't know if this affects on-going lock screen work -- we should really decouple the DOM between two, but maybe not in this bug.

Comment 12

[Guillaume Marty [:gmarty]]

Thanks Tim for the review. The scope of this blocker is to restore the functionality.
Any refactoring should be done in a separate bug.

I'll merge and close it for now, but keep the feedback? open.

Comment 13

[Guillaume Marty [:gmarty]]

Fixed in https://github.com/mozilla-b2g/gaia/commit/baa0a5bbf49904604543e83460ee683142c68867

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.1 approval on this when you get a chance.

Comment 15

[Guillaume Marty [:gmarty]]

Comment on attachment 8486429 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Regression caused by Bug 1038723
[User impact] if declined: the notifications on the lockscreen won't get updated.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]: None

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/ec3dab745668e34a487aea78a920fbd043ee5925

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

After I finally have time to clear my Bugzilla queue, I've realize the patch select *all* DOM with the class:

    var timestamps = document.getElementsByClassName('timestamp');

I think this is very improper. We should never assume the class only used by us, in the domain of Notifications!

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

I think we need to fire another bug to fix it. No matter whether it's a legacy behavior or not, it's just not correct.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

I've fixed this in LockScreen frame, while I'm manually rebasing it.

Comment 20

[Gerry Chang [:gchang]]

Verified @
Gaia      e731a63484c532168f4de6dc1eeb4c6612ad73a9
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/868cc9e5e32a
BuildID   20140915160206
Version   34.0a2

Comment 21

[Tony Chung [:tchung]]

Verified per comment 20 against 2.1 branch.   Gerry, dont forget when you verify on branch, you need to set the flag:  status-b2g-2.1 = "verified"   Marking status from RESOLVED => VERIFIED only gets you verification on trunk.

Comment 22

[Gerry Chang [:gchang]]

Hi Tony, 
Thanks for your reminder.