Closed
Bug 1061133
Opened 10 years ago
Closed 10 years ago
Update gaia-icons font with a Theme settings icon
Categories
(Firefox OS Graveyard :: Gaia::Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: olle.klang, Unassigned)
References
Details
Attachments
(2 files)
Posting this bug as a reminder to update the gaia-icons font with a Theme settings icon once it is ready, see Bug 1055104.
Comment 1•10 years ago
|
||
Hi Olle, the Theme icon is done, please see the attached zip file. I've updated 4 sizes PNG icons, also a SVG icon in case it's needed. Let me know if there is any question. Thanks!
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Helen Huang from comment #1) > Created attachment 8484866 [details] > icons.zip > > Hi Olle, the Theme icon is done, please see the attached zip file. I've > updated 4 sizes PNG icons, also a SVG icon in case it's needed. Let me know > if there is any question. Thanks! Great thanks Helen! I guess we need someone to help us make the icon a part of the gaia-icon font. NI Wilson Page, he seems to have done it before. Can you help us Wilson?
Flags: needinfo?(wilsonpage)
Comment 3•10 years ago
|
||
Added the theme icon to the gaia-icons set. I would normally merge this myself, but it seems that whenever I build on my machine the resulting font file is about twice as large. FYI: We'll need a second PR to update gaia-icons inside the Gaia repo once this has landed.
Attachment #8485672 -
Flags: review?(gmarty)
Flags: needinfo?(wilsonpage)
Comment 4•10 years ago
|
||
Comment on attachment 8485672 [details] [review] pull-request (gaia-icons:master) Fixed as per https://github.com/gaia-components/gaia-icons/commit/6efa8c7ea20189fc74cfb062f99f39e057fc2657
Attachment #8485672 -
Flags: review?(gmarty)
Updated•10 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•10 years ago
|
||
Thank you Wilson!
You need to log in
before you can comment on or make changes to this bug.
Description
•