Update gaia-icons font with a Theme settings icon

RESOLVED FIXED

Status

Firefox OS
Gaia::Components
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Olle Klang, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Posting this bug as a reminder to update the gaia-icons font with a Theme settings icon once it is ready, see Bug 1055104.
(Reporter)

Updated

4 years ago
Depends on: 1055104
Created attachment 8484866 [details]
icons.zip

Hi Olle, the Theme icon is done, please see the attached zip file. I've updated 4 sizes PNG icons, also a SVG icon in case it's needed. Let me know if there is any question. Thanks!
(Reporter)

Comment 2

4 years ago
(In reply to Helen Huang from comment #1)
> Created attachment 8484866 [details]
> icons.zip
> 
> Hi Olle, the Theme icon is done, please see the attached zip file. I've
> updated 4 sizes PNG icons, also a SVG icon in case it's needed. Let me know
> if there is any question. Thanks!

Great thanks Helen! I guess we need someone to help us make the icon a part of the gaia-icon font. NI Wilson Page, he seems to have done it before. 

Can you help us Wilson?
Flags: needinfo?(wilsonpage)
Created attachment 8485672 [details] [review]
pull-request (gaia-icons:master)

Added the theme icon to the gaia-icons set. I would normally merge this myself, but it seems that whenever I build on my machine the resulting font file is about twice as large.

FYI: We'll need a second PR to update gaia-icons inside the Gaia repo once this has landed.
Attachment #8485672 - Flags: review?(gmarty)
Flags: needinfo?(wilsonpage)
(Reporter)

Updated

4 years ago
Blocks: 1064709
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
See Also: → bug 1064903
(Reporter)

Comment 5

4 years ago
Thank you Wilson!
You need to log in before you can comment on or make changes to this bug.