1061134 - Update B2G's tools/update-tools/update-tools.py with DeleteFilesRecursive

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Andreas Pehrson [:pehrsons]]

DeleteFilesRecursive was added to edify_generator in bug 1058511.

Now we can switch tools/update-tools/update-tools.py to use that method instead of directly calling the updater's delete_recursive.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Use DeleteFilesRecursive from edify generator

Tested on my own local build. The updater-scripts produced before and after the patch are identical and contain the delete_recursive call.

Comment 2

[:gerard-majax]

Comment on attachment 8486419 [details] [review]
Use DeleteFilesRecursive from edify generator

That looks good, but I'm not a peer for this.

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8486419 [details] [review]
Use DeleteFilesRecursive from edify generator

(In reply to Alexandre LISSY :gerard-majax from comment #2)
> That looks good, 

Looks good to me too.

> but I'm not a peer for this.

Technically we don't have a module of which I'm peer. The review powers on this area were bestowed upon me when :dhylands moved to other stuff. It might be time to make this official and if we do you should definitely be a peer as you've written more stuff than me in this area in the past months.

Comment 4

[Andreas Pehrson [:pehrsons]]

I haven't landed this yet because I have been waiting for GP to land bug 1058511 on their fork. They did this a while ago, but I wasn't notified so I just noticed now.

Good news though, we can land this one!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/B2G/commit/b948ccf7c701ce10232d6c9d6e1af6c7fdccb1e8