1061150 - [Messages][Refresh] Change outgoing message background to #fff

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

*** Follow-up from bug 1041765 ***

Due to low contrast ratio between container and outgoing message backgrounds it was decided to change background for outgoing message from "#f5f5f5" to "#fff".

[Blocking Requested - why for this release]: blocking v2.1 feature

Comment 1

[Fang Shih [:fang]]

Please flag me for a UI review once the graphics are implemented, Thank you! :)

Comment 2

[Oleg Zasypkin [:azasypkin]]

Attachment: screenshot.png

Hey Fang,

Is it fine now?

Thanks!

Comment 3

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Hey Steve,

Here is a tiny patch that changes outgoing message background to #fff, could you please review it once we get ui-review+?

Thanks!

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8482222 [details] [review]
GitHub pull request URL

Let's wait for ui review :)

Comment 5

[Oleg Zasypkin [:azasypkin]]

Attachment: screenshot_with_box_shadow.png

Fang, Steve, sorry I've just realized that I forgot to add box-shadow to message bubbles in thread view refresh patch.

Fang, please look at the screenshot and say if it's still needed :)

Steve, I've updated PR with it too, so re-requesting review. There is a chance that it may have performance impact, but it will be easy to remove it in this case. So I think it's worth trying :)

Thanks!

Comment 6

[Fang Shih [:fang]]

Comment on attachment 8482257 [details]
screenshot_with_box_shadow.png

 Yay!!!!! Looks great! Thanks for all your help Oleg! :)

Comment 7

[Steve Chung [:steveck]]

Comment on attachment 8482222 [details] [review]
GitHub pull request URL

Hi Oleg, question replied on github. I'm fine with your solution, just letting you know why we did this before :)

Comment 8

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #7)
> Comment on attachment 8482222 [details] [review]
> GitHub pull request URL
> 
> Hi Oleg, question replied on github. I'm fine with your solution, just
> letting you know why we did this before :)

Thanks for review! Finally I ended up using solution you suggested, I like it more :)

Master: https://github.com/mozilla-b2g/gaia/commit/273fda9d359a0ee52072b1588b9134e510d19780

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: non-blocking. high-want to uplift.

Comment 10

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Oleg, can you ask approval to uplift this?

Comment 11

[Oleg Zasypkin [:azasypkin]]

Wesley, I believe it has been landed before branching, so it should be in v2.1 already - at least I see it in v2.1 pvt build

Comment 12

[Maria Angeles Oteo (:oteo)]

(In reply to Oleg Zasypkin [:azasypkin] from comment #11)
> Wesley, I believe it has been landed before branching, so it should be in
> v2.1 already - at least I see it in v2.1 pvt build

In that case, setting the tracking flags according to this.
Thanks Oleg!