Closed Bug 1061150 Opened 6 years ago Closed 6 years ago

[Messages][Refresh] Change outgoing message background to #fff

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(tracking-b2g:backlog, b2g-v2.1 fixed, b2g-v2.2 fixed)

RESOLVED FIXED
tracking-b2g backlog
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Whiteboard: [sms-sprint-2.1S3])

Attachments

(3 files)

*** Follow-up from bug 1041765 ***

Due to low contrast ratio between container and outgoing message backgrounds it was decided to change background for outgoing message from "#f5f5f5" to "#fff".

[Blocking Requested - why for this release]: blocking v2.1 feature
Please flag me for a UI review once the graphics are implemented, Thank you! :)
Attached image screenshot.png
Hey Fang,

Is it fine now?

Thanks!
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Attachment #8482220 - Flags: ui-review?(fshih)
Hey Steve,

Here is a tiny patch that changes outgoing message background to #fff, could you please review it once we get ui-review+?

Thanks!
Attachment #8482222 - Flags: review?(schung)
Comment on attachment 8482222 [details] [review]
GitHub pull request URL

Let's wait for ui review :)
Attachment #8482222 - Flags: review?(schung) → review+
Fang, Steve, sorry I've just realized that I forgot to add box-shadow to message bubbles in thread view refresh patch.

Fang, please look at the screenshot and say if it's still needed :)

Steve, I've updated PR with it too, so re-requesting review. There is a chance that it may have performance impact, but it will be easy to remove it in this case. So I think it's worth trying :)

Thanks!
Attachment #8482257 - Flags: ui-review?(fshih)
Attachment #8482222 - Flags: review+ → review?(schung)
Comment on attachment 8482257 [details]
screenshot_with_box_shadow.png

 Yay!!!!! Looks great! Thanks for all your help Oleg! :)
Attachment #8482257 - Flags: ui-review?(fshih) → ui-review+
Attachment #8482220 - Flags: ui-review?(fshih) → ui-review+
Comment on attachment 8482222 [details] [review]
GitHub pull request URL

Hi Oleg, question replied on github. I'm fine with your solution, just letting you know why we did this before :)
Attachment #8482222 - Flags: review?(schung) → review+
(In reply to Steve Chung [:steveck] from comment #7)
> Comment on attachment 8482222 [details] [review]
> GitHub pull request URL
> 
> Hi Oleg, question replied on github. I'm fine with your solution, just
> letting you know why we did this before :)

Thanks for review! Finally I ended up using solution you suggested, I like it more :)

Master: https://github.com/mozilla-b2g/gaia/commit/273fda9d359a0ee52072b1588b9134e510d19780
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
triage: non-blocking. high-want to uplift.
blocking-b2g: 2.1? → backlog
Oleg, can you ask approval to uplift this?
Flags: needinfo?(azasypkin)
Wesley, I believe it has been landed before branching, so it should be in v2.1 already - at least I see it in v2.1 pvt build
Flags: needinfo?(azasypkin)
(In reply to Oleg Zasypkin [:azasypkin] from comment #11)
> Wesley, I believe it has been landed before branching, so it should be in
> v2.1 already - at least I see it in v2.1 pvt build

In that case, setting the tracking flags according to this.
Thanks Oleg!
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.