1061241 - Potential leak in DrawTargetSkia::MaskSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

While reviewing Moz2D code I noticed that I think during some of the conversions in bug 1017113 we accidentally introduced a leak into DrawTargetSkia::MaskSurface.

Namely I believe at DrawTargetSkia.cpp:588

-maskPaint.setShader(matrixShader);
+SkSafeUnref(maskPaint.setShader(matrixShader));

Comment 1

[George Wright (:gw280) (needinfo me!)]

https://tbpl.mozilla.org/?tree=Try&rev=587c30abfa19

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

I imagine we will want this uplifted to aurora/b2g34.

Comment 3

[George Wright (:gw280) (needinfo me!)]

Attachment: unref-shader.patch

Comment 4

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89f165978438

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out because it seems to have made mochitest-4 fail on a couple platforms:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=mochitest-4&rev=89f165978438 (if you click the green down arrow to load earlier pushes, m4 was pretty much green prior to this landing)

https://hg.mozilla.org/integration/mozilla-inbound/rev/83828ef2601e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/accfce64d9df because bug 982726 seems more likely to blame.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/accfce64d9df