Potential leak in DrawTargetSkia::MaskSurface

RESOLVED FIXED in mozilla35

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bas, Assigned: gw280)

Tracking

unspecified
mozilla35
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
While reviewing Moz2D code I noticed that I think during some of the conversions in bug 1017113 we accidentally introduced a leak into DrawTargetSkia::MaskSurface.

Namely I believe at DrawTargetSkia.cpp:588

-maskPaint.setShader(matrixShader);
+SkSafeUnref(maskPaint.setShader(matrixShader));
(Assignee)

Updated

3 years ago
Assignee: nobody → gwright
https://tbpl.mozilla.org/?tree=Try&rev=587c30abfa19
I imagine we will want this uplifted to aurora/b2g34.
Created attachment 8483109 [details] [diff] [review]
unref-shader.patch
Attachment #8483109 - Flags: review?(matt.woodrow)
Attachment #8483109 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/89f165978438
I had to back this out because it seems to have made mochitest-4 fail on a couple platforms:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=mochitest-4&rev=89f165978438 (if you click the green down arrow to load earlier pushes, m4 was pretty much green prior to this landing)

https://hg.mozilla.org/integration/mozilla-inbound/rev/83828ef2601e
Flags: needinfo?(gwright)
Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/accfce64d9df because bug 982726 seems more likely to blame.
Flags: needinfo?(gwright)
https://hg.mozilla.org/mozilla-central/rev/accfce64d9df
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.