Closed Bug 1061241 Opened 7 years ago Closed 7 years ago

Potential leak in DrawTargetSkia::MaskSurface

Categories

(Core :: Graphics, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: bas.schouten, Assigned: gw280)

References

Details

Attachments

(1 file)

While reviewing Moz2D code I noticed that I think during some of the conversions in bug 1017113 we accidentally introduced a leak into DrawTargetSkia::MaskSurface.

Namely I believe at DrawTargetSkia.cpp:588

-maskPaint.setShader(matrixShader);
+SkSafeUnref(maskPaint.setShader(matrixShader));
Assignee: nobody → gwright
I imagine we will want this uplifted to aurora/b2g34.
Attachment #8483109 - Flags: review?(matt.woodrow)
Attachment #8483109 - Flags: review?(matt.woodrow) → review+
I had to back this out because it seems to have made mochitest-4 fail on a couple platforms:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=mochitest-4&rev=89f165978438 (if you click the green down arrow to load earlier pushes, m4 was pretty much green prior to this landing)

https://hg.mozilla.org/integration/mozilla-inbound/rev/83828ef2601e
Flags: needinfo?(gwright)
https://hg.mozilla.org/mozilla-central/rev/accfce64d9df
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.