Closed
Bug 1061269
Opened 11 years ago
Closed 11 years ago
Do not try to build the SkBlitRow assembly implementation with clang-cl
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.92 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
clang-cl builds use ml.exe which is the MASM assembler, same as the one
we use for MSVC builds. In that respect, clang-cl and gcc builds are
quite different.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8482347 -
Flags: review?(snorp)
|
||
Comment 2•11 years ago
|
||
I think we just shouldn't build it at all for Windows targets (skia doesn't use it then anyway). This will be fixed as part of bug 1060361.
|
||
Updated•11 years ago
|
Attachment #8482347 -
Flags: review?(snorp) → review+
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•