Closed Bug 1061269 Opened 7 years ago Closed 7 years ago

Do not try to build the SkBlitRow assembly implementation with clang-cl

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

clang-cl builds use ml.exe which is the MASM assembler, same as the one
we use for MSVC builds.  In that respect, clang-cl and gcc builds are
quite different.
Assignee: nobody → ehsan.akhgari
Blocks: winclang
Attachment #8482347 - Flags: review?(snorp)
I think we just shouldn't build it at all for Windows targets (skia doesn't use it then anyway). This will be fixed as part of bug 1060361.
Attachment #8482347 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/d5e6df0a3f5a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.