1061290 - gaia:test_agent add chai expect and should interface

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[sv99]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.94 Safari/537.36

Steps to reproduce:

chia enable only assert interface, not enabled expect and should interfaces 

For testing existing property in objects used assert.include, specified for string and array, not for simple object.

dev_apps/test-agent/common/test/helper.js View  
 @@ -111,6 +111,8 @@
     chai.Assertion.includeStack = true;
     patchChai(chai.Assertion);
     window.assert = chai.assert;
+    window.expect = chai.expect;
+    window.should = chai.should();
   });



Actual results:

sample using assert.include

apps/clock/test/unit/picker/picker_test.js View  
 
   test('shape:prototype ', function() {
     assert.ok(Picker);
     assert.include(Picker.prototype, 'reset');
+    assert.include(Picker.prototype, 'reset1'); // assert OK!! this property not exists !!
     assert.include(Picker.prototype, 'value');
     assert.isNull(Picker.prototype.value);
   });


Expected results:

apps/clock/test/unit/picker/picker_test.js View  
 @@ -15,7 +15,10 @@ suite('Picker', function() {
 
   test('shape:prototype ', function() {
     assert.ok(Picker);
+    expect(Picker.prototype).to.have.property('reset');
+    Picker.prototype.should.to.have.property('value');
     assert.isNull(Picker.prototype.value);
   });

Comment 1

[sv99]

Attachment: 1061290.diff

Comment 2

[sv99]

PR https://github.com/mozilla-b2g/gaia/pull/23613

Comment 3

[sv99]

Attachment: PR

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

sv99, I left comment on github, please take a look.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

sv99 has replied on github.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8482551 [details] [review]
PR

that looks good, but we should have a test case to catch it, I will upload a attchment for test case, please apply it to your pull request and squash to one commit and needinfo? me if your pull request is updated.

thanks for your contribution!

Comment 7

[sv99]

Attachment: PR

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8484123 [details] [review]
PR

I forgot to upload my patch yesterday and you test case looks good so let's land your pull request, thank you!

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

sv99, please squash commits in your pull request to one commit for merging.

Comment 10

[sv99]

(In reply to Yuren [:yurenju] from comment #9)
> sv99, please squash commits in your pull request to one commit for merging.

commit squashed

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged, thanks for this contribution!

https://github.com/mozilla-b2g/gaia/commit/df383142490620d259e7a7b4a0a46a930242a339

Comment 12

[Julien Wajsberg [:julienw]]

I'm not sure we should support "should", it looks quite useless in our cases (see my comment on the commit).

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

replied on github.

https://github.com/mozilla-b2g/gaia/commit/df383142490620d259e7a7b4a0a46a930242a339#commitcomment-7793014