Remove obsolete entries from admin add-on and file status page

RESOLVED FIXED in 2014-09

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: TheOne, Assigned: kmag)

Tracking

unspecified
2014-09

Details

(Whiteboard: [ReviewTeam][contribute])

(Reporter)

Description

4 years ago
Let's remove old and obsolete drop down menus and entries from the admin add-on status pag (e.g. https://addons.mozilla.org/en-US/admin/addon/manage/selite-db-objects/)

Afaik, "Highest" and "Outstanding" can both be deleted.
Files are never pending for full approval, we should probably rename "Awaiting Preliminary Review" to "Awaiting Review".

What else is obsolete?
(In reply to Andreas Wagner [:TheOne] from comment #0)
> Afaik, "Highest" and "Outstanding" can both be deleted.

Yes, I think those can be removed safely. I would also use this bug to make sure Highest isn't in use at all and get rid of it entirely.

> Files are never pending for full approval, we should probably rename
> "Awaiting Preliminary Review" to "Awaiting Review".

That's bug 699352.

> What else is obsolete?

The rest seems to be useful. The 'Copied' column could be removed, maybe. It's possible it could be used to debug some missing file problems, but I'm not sure.
(Assignee)

Comment 2

4 years ago
(In reply to Jorge Villalobos [:jorgev] from comment #1)
> (In reply to Andreas Wagner [:TheOne] from comment #0)
> > Afaik, "Highest" and "Outstanding" can both be deleted.
> 
> Yes, I think those can be removed safely. I would also use this bug to make
> sure Highest isn't in use at all and get rid of it entirely.

Outstanding can be removed. Highest is used and needs to stay.

(In reply to Andreas Wagner [:TheOne] from comment #0)
> What else is obsolete?

Most of the items are not obsolete. They just don't apply for all of the drop-downs that they appear in.
Assignee: nobody → kmaglione+bmo
(Assignee)

Comment 4

4 years ago
https://github.com/mozilla/olympia/pull/247
Target Milestone: --- → 2014-09
(In reply to Kris Maglione [:kmag] from comment #2)
> > Yes, I think those can be removed safely. I would also use this bug to make
> > sure Highest isn't in use at all and get rid of it entirely.
> 
> Outstanding can be removed. Highest is used and needs to stay.

What is Highest being used for? More often than not it has an incorrect value.
Flags: needinfo?(kmaglione+bmo)
(Assignee)

Comment 6

4 years ago
It's used to decide whether to soft delete an add-on, and whether to add its ID to the blacklist. When add-ons which have never passed review are deleted, their IDs can be reused. IDs of reviewed add-ons can't.
Flags: needinfo?(kmaglione+bmo)
PR: https://github.com/mozilla/olympia/pull/247
Fixed in: https://github.com/mozilla/olympia/commit/287174820d80f22d7867b7d596ef11c9d09fc1b2

Thanks Kris!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.