Closed Bug 1061428 Opened 10 years ago Closed 10 years ago

Huge performance regression: Computing hash a big file is slow(x5) since Firefox32

Categories

(Core :: JavaScript Engine: JIT, defect)

32 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1054972
Tracking Status
firefox32 - ---

People

(Reporter: alice0775, Unassigned)

References

Details

(Keywords: perf, regression)

[Tracking Requested - why for this release]: Huge performance regression

Steps To Reproduce:
1. Open https://www.virustotal.com/
2. Choose big file (more 30MB) and Click [Scan it!]
  --- observe progress of "Computing hash"

Actual Results:
On my low spec PC
Firefox32---  It takes about 30sec
Firefos31---  It takes about 6sec

Regression window(m-c)
Good:
https://hg.mozilla.org/mozilla-central/rev/cf89b5d018f8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140508190639
Bad:
https://hg.mozilla.org/mozilla-central/rev/373e31d211f3
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140509050132
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cf89b5d018f8&tochange=373e31d211f3


Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbef254f0aa5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140508180436
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b66e279688a1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140508183858
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fbef254f0aa5&tochange=b66e279688a1
Regressed by:
b66e279688a1	Dan Gohman — Bug 998580 - IonMonkey: Generalize RangeAnalysis truncation to handle other kinds of paths to integer types. r=nbp
I'd say this is a duplicate of Bug 1054972.
Flags: needinfo?(sunfish)
Firefox 32 shipped today. Although a large regression, unless this is shown to impact a lot of regular use cases, we're not likely to chemspill for this. I have set tracking- for 32 and tracking+ for 33+.
Confirmed in m-c tinderbox build.
https://hg.mozilla.org/mozilla-central/rev/acbdce59da2f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140903133924

This was fixed by Bug 1054972.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Comment 3 confirms this is fixed.
Flags: needinfo?(sunfish)
You need to log in before you can comment on or make changes to this bug.