Closed Bug 1061432 Opened 10 years ago Closed 10 years ago

Remove "number" type in fr-CA.json keyboard layout

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S4 (12sep)

People

(Reporter: mnjul, Assigned: mnjul)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Patch (PR @ GitHub)
46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review 
During the short lifetime of bug 1024298's patch, a new keyboard layout, fr-CA, was added to gaia tree, which copied "number" type support from other layouts. Such support should have been removed when bug 1024298 was backed-out, and this bug will deal with it.

If we leave it there, anomaly such as bug 942309 comment 30 could happen.
Attached file Patch (PR @ GitHub) — 
Rudy, please review the one-liner patch for me. Thanks!
Attachment #8482511 - Flags: review?(rlu)
Comment on attachment 8482511 [details] [review]
Patch (PR @ GitHub)

r=me.
John, thanks for catching this!
Attachment #8482511 - Flags: review?(rlu) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/c8cf5ed518e9aefe36cf6d325a6a13b44cbe8f6f

Merged in spite of Gip error which everyone else also has.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: