Closed Bug 1061447 Opened 9 years ago Closed 9 years ago

Fix error handling in ChannelMediaResource::RecreateChannel()

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

1061447_fix_ChannelMediaResource_error_handling.patch
1.62 KB, patch
roc
: review+
Details | Diff | Splinter Review 
http://hg.mozilla.org/mozilla-central/file/532b5fb77ba1/content/media/MediaResource.cpp#l933

mChannel could become null if NS_NewChannel fails and |mChannel->SetContentType| below will crash. Though it is kinda unlikely to happen, lets add some error handling to keep the code in good shape.
Bail out if NS_NewChannel() fails to create a channel.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8482532 - Flags: review?(roc)
Since it is a simple change, I will save the Try.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3991b2377ab
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.