Closed
Bug 1061447
Opened 10 years ago
Closed 10 years ago
Fix error handling in ChannelMediaResource::RecreateChannel()
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/file/532b5fb77ba1/content/media/MediaResource.cpp#l933 mChannel could become null if NS_NewChannel fails and |mChannel->SetContentType| below will crash. Though it is kinda unlikely to happen, lets add some error handling to keep the code in good shape.
|
Assignee | |
Comment 1•10 years ago
|
||
Bail out if NS_NewChannel() fails to create a channel.
Attachment #8482532 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Since it is a simple change, I will save the Try.
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3991b2377ab
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c3991b2377ab
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•