Closed
Bug 1061450
Opened 11 years ago
Closed 11 years ago
Confirmation of deletion screen in APN editor is not the right one
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brg, Assigned: arthurcc)
Details
(Keywords: late-l10n)
Attachments
(2 files)
2014-09-02-09-34-36.png
I am not a UX expert but I think that all the confirmation screens when user deletes something had a different UI with red colors intead of blue.
Tested today with master(2.1) Flame Gecko-2fbbb04.Gaia-59bd661, see screenshot.
|
Assignee | |
Comment 1•11 years ago
|
||
Yes, based on the UX spec the color of the button should be red.
Assignee: nobody → arthur.chen
|
|
Assignee | |
Comment 2•11 years ago
|
||
Hi EJ, could you help review this simple patch? Thanks.
Attachment #8483296 -
Flags: review?(ejchen)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8483296 [details]
link to https://github.com/mozilla-b2g/gaia/pull/23663
left some nits on github, please check them before merging, thanks :) r+
And I noticed the title of PR is not consistent with the one in bugzilla, please remember to update it.
Attachment #8483296 -
Flags: review?(ejchen) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Thanks, EJ!
master: 6da383d6dbed03c70878cf9a2452c7dfe34d952d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•