1061513 - Execute jshint for tests directory

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Sudheesh Singanamalla (:ShellHacker)]

This is the main tracking bug for executing jshint tests on the various js files present in the tests directory and its subdirectories.

Comment 1

[Sudheesh Singanamalla (:ShellHacker)]

Blocker cleared.

.jshintignore file updated
Ready to patch dependant bugs.

Comment 2

[Kevin Grandon :kgrandon]

Hi Sudheesh - to be honest, I think you may want to stop working on these tests until we get clarification if they are still in use. I have a feeling that we may not use them, and we can probably delete them. I will check on this now. Doing a ni? on you for awareness.

Comment 3

[Kevin Grandon :kgrandon]

As a reminder, the list of files that we need to fix JSHint for can be found here: https://github.com/mozilla-b2g/gaia/blob/master/build/jshint/xfail.list

Comment 4

[Sudheesh Singanamalla (:ShellHacker)]

Kevin,
I am not aware of if we should be deleting these files, hence I can't really say anything about that.
If we decide on deleting a few of these tests, well close the relevant bugs as FIXED.

The xfail.list has only apps/ and shared/ files, we can keep a tracker and work on those instead with a hope to clear that file.

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Sudheesh Singanamalla (:ShellHacker) from comment #4)
> Kevin,
> I am not aware of if we should be deleting these files, hence I can't really
> say anything about that.
> If we decide on deleting a few of these tests, well close the relevant bugs
> as FIXED.
> 
> The xfail.list has only apps/ and shared/ files, we can keep a tracker and
> work on those instead with a hope to clear that file.

Sounds good. It would still be useful to do the files in the tests/ directory, but just be aware of the files that might be deleted in bug 1082329. Thanks for your contributions!

Comment 6

[Sudheesh Singanamalla (:ShellHacker)]

(In reply to Kevin Grandon :kgrandon from comment #5)

I enjoyed contributing so far and understood the codebase pretty well. Thanks for patiently reviewing everything so far and being great mentors. I would love to pick on the xfail.list later.

> (In reply to Sudheesh Singanamalla (:ShellHacker) from comment #4)
> > Kevin,
> > I am not aware of if we should be deleting these files, hence I can't really
> > say anything about that.
> > If we decide on deleting a few of these tests, well close the relevant bugs
> > as FIXED.
> > 
> > The xfail.list has only apps/ and shared/ files, we can keep a tracker and
> > work on those instead with a hope to clear that file.

I've cc'd myself on that bug , I'll work depending on the result of that

> Sounds good. It would still be useful to do the files in the tests/
> directory, but just be aware of the files that might be deleted in bug
> 1082329. Thanks for your contributions!

Comment 7

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/25176

Fixes hint errors in all files except

1. tests/performance/exec-sync.js

This looks like an external file, should this also be patched, or should this be patched in the respective project's upstream.

2. tests/atoms/remote_date.js
3. tests/atoms/screenshot.js

Here is the Possible strict violation, Strict violation.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8505387 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25176

Thank you for the patch. This is really close but needs a bit more work before we can land it. Please address my comments on github and re-flag me for review.

Comment 10

[Sudheesh Singanamalla (:ShellHacker)]

Comment on attachment 8505387 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25176

Updated. Hopefully should be fine now ?

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8505387 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25176

This looks good to me. Thank you for your contribution!

Comment 12

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/f72283cbe38ba0430fca62f6a25f9af20eac8c28

Sudheesh - Could you help us and remove the dependent bugs which have been landed as a part of this? Thank you for doing this!

Comment 13

[Sudheesh Singanamalla (:ShellHacker)]

Thanks for reviewing it and helping me out Kevin. I've closed the dependant bugs which have landed because of this with a comment on each bug saying |Fixed by https://github.com/mozilla-b2g/gaia/commit/f72283cbe38ba0430fca62f6a25f9af20eac8c28| 

I've left the 4 Bugs which haven't been fixed with the status NEW, should I resolve them to RESOLVED WONTFIX ?

I would love to take on a new bug and clearing xfail.list seems to be a good one there. Could you guide me through that, or assign me a new bug

Comment 14

[Kevin Grandon :kgrandon]

(In reply to Sudheesh Singanamalla (:ShellHacker) from comment #13)
> Thanks for reviewing it and helping me out Kevin. I've closed the dependant
> bugs which have landed because of this with a comment on each bug saying
> |Fixed by
> https://github.com/mozilla-b2g/gaia/commit/
> f72283cbe38ba0430fca62f6a25f9af20eac8c28| 
> 
> I've left the 4 Bugs which haven't been fixed with the status NEW, should I
> resolve them to RESOLVED WONTFIX ?

Sure, I've done this.


> I would love to take on a new bug and clearing xfail.list seems to be a good
> one there. Could you guide me through that, or assign me a new bug

Sounds good - there is still a bunch of work to be done there. I've filed bug 1084191 as a meta bug to track this work, and will NI? you on a few bugs - or you can file bugs for the remaining work there, but you may want to check with app authors before doing so.