Closed
Bug 1061519
Opened 10 years ago
Closed 10 years ago
Fix jshint error in tests/atoms/gaia_apps.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ShellHacker, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Attachment #8492971 -
Flags: review?(yurenju)
Comment 2•10 years ago
|
||
Comment on attachment 8492971 [details] [review] https://github.com/mozilla-b2g/gaia/pull/24274 Sudheesh, please rewrite numRunningApps() to pass jshint, otherwise looks good, r=yurenju needinfo me if your pull request is updated to merge it.
Attachment #8492971 -
Flags: review?(yurenju) → review+
Comment 4•10 years ago
|
||
Sedheesh, please rebase since we got conflict again.
Flags: needinfo?(yurenju) → needinfo?(sudheesh1995)
Reporter | ||
Comment 5•10 years ago
|
||
Sorry to obsolete the older pull request and provide a new one, I had too many merge conflicts to clear while rebasing, thought it'd be easier to pull from upstream and send a new pull request instead.
Attachment #8492971 -
Attachment is obsolete: true
Attachment #8497296 -
Flags: review?(yurenju)
Flags: needinfo?(sudheesh1995)
Reporter | ||
Comment 6•10 years ago
|
||
Can the pull request be reopened and merged if the review is an r+, autolander closed this PR.
Flags: needinfo?(yurenju)
Reporter | ||
Comment 7•10 years ago
|
||
Fabrice, It looks like Yuren's slightly busy, Could you open this pull request and check If I have to rebase ?
Flags: needinfo?(fabrice)
Updated•10 years ago
|
Flags: needinfo?(fabrice)
Reporter | ||
Comment 8•10 years ago
|
||
Comment on attachment 8497296 [details] [review] https://github.com/mozilla-b2g/gaia/pull/24542 Rebased, removed conflict. Requesting review.
Attachment #8497296 -
Flags: review?(fabrice)
Updated•10 years ago
|
Attachment #8497296 -
Flags: review?(yurenju)
Attachment #8497296 -
Flags: review?(fabrice)
Attachment #8497296 -
Flags: review+
Comment 9•10 years ago
|
||
Sudheesh, can you update the commit message to say r=fabrice instead of r=yurenju? thanks!
Comment 11•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/9903497debc38227a158e4719871f1ac73691113
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(fabrice)
Resolution: --- → FIXED
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(yurenju)
You need to log in
before you can comment on or make changes to this bug.
Description
•