Closed Bug 1061520 Opened 10 years ago Closed 10 years ago

Fix jshint error in tests/atoms/gaia_data_layer.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ShellHacker, Unassigned)

References

Details

Attachments

(1 file)

      No description provided.
Comment on attachment 8497316 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24546

Redirecting the review to Zac since you touch the test code itself.
Attachment #8497316 - Flags: review?(fabrice) → review?(zcampbell)
Thanks Sudheesh! I have to leave for the day but I've set up an automated run so I can check the results in the morning.

Apologies you may not be able to see it (it's moz internal hosted) but it's running here:
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/174/console

I'll r? it in the morning, cheers!
Zac,

autolander has closed this pull request, if the review is an r+, you could reopen it and merge.
Flags: needinfo?(zcampbell)
Hi Sudheesh, our test run was a perfect green!

I re-opened the pull request but it has merge conflicts. Can you rebase your pull?
Flags: needinfo?(zcampbell)
Rebased and pushed back :)
Flags: needinfo?(zcampbell)
Comment on attachment 8497316 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24546

Stealing Zac's review and r- based on just a couple of nits.
Attachment #8497316 - Flags: review?(zcampbell) → review-
Flags: needinfo?(zcampbell)
Dave, Fixed them ! How about now ?
Flags: needinfo?(dave.hunt)
Still r- see comments in pull request.
Flags: needinfo?(dave.hunt)
Updated it. Requesting review
Flags: needinfo?(dave.hunt)
Attachment #8497316 - Flags: review?(zcampbell)
Looks like they timed out. Whats the work around here ?
Flags: needinfo?(zcampbell)
(In reply to Sudheesh Singanamalla (:ShellHacker) from comment #12)
> Looks like they timed out. Whats the work around here ?

There's no workaround. Your change appears to have caused removeAllContacts to never return and therefore it times out. You'll either need to revert your change here or fix it so that the method called marionetteScriptFinished when there are no more contacts.
Flags: needinfo?(zcampbell)
Flags: needinfo?(dave.hunt)
(In reply to Dave Hunt (:davehunt) from comment #13)
> (In reply to Sudheesh Singanamalla (:ShellHacker) from comment #12)

> There's no workaround. Your change appears to have caused removeAllContacts
> to never return and therefore it times out. You'll either need to revert
> your change here or fix it so that the method called
> marionetteScriptFinished when there are no more contacts.

Reverted the commit. Resolved merge conflicts, updated the patch. pushed back to the same PR. How about now ?
Flags: needinfo?(zcampbell)
Flags: needinfo?(dave.hunt)
The python integration tests are still failing. Could someone guide me through this ?
My bad. Realized I was looking through the wrong try result.

Try: https://tbpl.mozilla.org/?rev=eb830cd92487d26449139d2a8804dfb43351ad0a&tree=Gaia-Try
The tests look fine now, but you've included a temp_gaia_data_layer.js in your patch. Was this intentional?
Flags: needinfo?(zcampbell)
Flags: needinfo?(dave.hunt)
Oops. That was unintentional. Fixed it now. Removed that temp file, I kept it as a copy of the original updated file before I fixed the merge conflict. Pushed back an update to the same PR. Everything should be fine now ?
Flags: needinfo?(dave.hunt)
Removed merge conflict, rebased and pushed back onto the PR
Flags: needinfo?(fabrice)
Comment on attachment 8497316 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24546

Looks good now, thanks! Please update your commit message to indicate me as the reviewer. Let me know if you need me to land this for you.
Attachment #8497316 - Flags: review-
Attachment #8497316 - Flags: review+
Flags: needinfo?(fabrice)
Flags: needinfo?(dave.hunt)
I updated the commit message to indicate you as my reviewer. Thanks for reviewing this. I request you to land this for me as I don't have the required write permissions
Flags: needinfo?(dave.hunt)
The git commit message still had Fabrice as the reviewer so I fixed this up when I merged.

Landed in:
https://github.com/mozilla-b2g/gaia/commit/8d089e2abe2ce1975fe3b84611c8ee1126daf82d
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(dave.hunt)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: