Closed
Bug 1061520
Opened 10 years ago
Closed 10 years ago
Fix jshint error in tests/atoms/gaia_data_layer.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ShellHacker, Unassigned)
References
Details
Attachments
(1 file)
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Attachment #8497316 -
Flags: review?(fabrice)
Comment 2•10 years ago
|
||
Comment on attachment 8497316 [details] [review] https://github.com/mozilla-b2g/gaia/pull/24546 Redirecting the review to Zac since you touch the test code itself.
Attachment #8497316 -
Flags: review?(fabrice) → review?(zcampbell)
Comment 3•10 years ago
|
||
Thanks Sudheesh! I have to leave for the day but I've set up an automated run so I can check the results in the morning. Apologies you may not be able to see it (it's moz internal hosted) but it's running here: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/174/console I'll r? it in the morning, cheers!
Reporter | ||
Comment 4•10 years ago
|
||
Zac, autolander has closed this pull request, if the review is an r+, you could reopen it and merge.
Flags: needinfo?(zcampbell)
Comment 5•10 years ago
|
||
Hi Sudheesh, our test run was a perfect green! I re-opened the pull request but it has merge conflicts. Can you rebase your pull?
Flags: needinfo?(zcampbell)
Comment 7•10 years ago
|
||
Comment on attachment 8497316 [details] [review] https://github.com/mozilla-b2g/gaia/pull/24546 Stealing Zac's review and r- based on just a couple of nits.
Attachment #8497316 -
Flags: review?(zcampbell) → review-
Flags: needinfo?(zcampbell)
Reporter | ||
Comment 8•10 years ago
|
||
Dave, Fixed them ! How about now ?
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(dave.hunt)
Reporter | ||
Updated•10 years ago
|
Attachment #8497316 -
Flags: review?(zcampbell)
Comment 11•10 years ago
|
||
Comment on attachment 8497316 [details] [review] https://github.com/mozilla-b2g/gaia/pull/24546 Sorry but test_cleanup_gaia.py is failing :( https://tbpl.mozilla.org/?rev=6b23f44e3ebd842db355f155cd1fb72d58ad7cd0&tree=Gaia-Try
Attachment #8497316 -
Flags: review?(zcampbell) → review-
Reporter | ||
Comment 12•10 years ago
|
||
Looks like they timed out. Whats the work around here ?
Flags: needinfo?(zcampbell)
Comment 13•10 years ago
|
||
(In reply to Sudheesh Singanamalla (:ShellHacker) from comment #12) > Looks like they timed out. Whats the work around here ? There's no workaround. Your change appears to have caused removeAllContacts to never return and therefore it times out. You'll either need to revert your change here or fix it so that the method called marionetteScriptFinished when there are no more contacts.
Flags: needinfo?(zcampbell)
Flags: needinfo?(dave.hunt)
Reporter | ||
Comment 14•10 years ago
|
||
(In reply to Dave Hunt (:davehunt) from comment #13) > (In reply to Sudheesh Singanamalla (:ShellHacker) from comment #12) > There's no workaround. Your change appears to have caused removeAllContacts > to never return and therefore it times out. You'll either need to revert > your change here or fix it so that the method called > marionetteScriptFinished when there are no more contacts. Reverted the commit. Resolved merge conflicts, updated the patch. pushed back to the same PR. How about now ?
Flags: needinfo?(zcampbell)
Flags: needinfo?(dave.hunt)
Reporter | ||
Comment 15•10 years ago
|
||
The python integration tests are still failing. Could someone guide me through this ?
Reporter | ||
Comment 16•10 years ago
|
||
My bad. Realized I was looking through the wrong try result. Try: https://tbpl.mozilla.org/?rev=eb830cd92487d26449139d2a8804dfb43351ad0a&tree=Gaia-Try
Comment 17•10 years ago
|
||
The tests look fine now, but you've included a temp_gaia_data_layer.js in your patch. Was this intentional?
Flags: needinfo?(zcampbell)
Flags: needinfo?(dave.hunt)
Reporter | ||
Comment 18•10 years ago
|
||
Oops. That was unintentional. Fixed it now. Removed that temp file, I kept it as a copy of the original updated file before I fixed the merge conflict. Pushed back an update to the same PR. Everything should be fine now ?
Flags: needinfo?(dave.hunt)
Reporter | ||
Comment 19•10 years ago
|
||
Removed merge conflict, rebased and pushed back onto the PR
Flags: needinfo?(fabrice)
Comment 20•10 years ago
|
||
Comment on attachment 8497316 [details] [review] https://github.com/mozilla-b2g/gaia/pull/24546 Looks good now, thanks! Please update your commit message to indicate me as the reviewer. Let me know if you need me to land this for you.
Attachment #8497316 -
Flags: review-
Attachment #8497316 -
Flags: review+
Flags: needinfo?(fabrice)
Flags: needinfo?(dave.hunt)
Reporter | ||
Comment 21•10 years ago
|
||
I updated the commit message to indicate you as my reviewer. Thanks for reviewing this. I request you to land this for me as I don't have the required write permissions
Flags: needinfo?(dave.hunt)
Comment 22•10 years ago
|
||
The git commit message still had Fabrice as the reviewer so I fixed this up when I merged. Landed in: https://github.com/mozilla-b2g/gaia/commit/8d089e2abe2ce1975fe3b84611c8ee1126daf82d
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(dave.hunt)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•