Closed Bug 1061559 Opened 10 years ago Closed 9 years ago

[User Story] As a Helpee I can mark as helpful a specific comment, so that I can notify the helper that his comment helped me.

Categories

(support.mozilla.org :: BuddyUp, defect, P2)

All
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
2014Q4

People

(Reporter: RT, Assigned: espressive)

References

Details

(Whiteboard: p=1 s=bu.2015.1)

User Story

As a Helpee I can mark as helpful a specific comment, so that I can notify the helper that his comment helped me. This is possible on resolved or non resolved questions.

Acceptance criteria:
* A “thumb up” icon is displayed on each helper comment with a number indicating the number of times it’s been selected by individual helpees
* Pressing the “thumb up” icon increases the “thumb up” counter, turns the thumb up color to blue and prompts a notification to the helpee at the bottom of the screen: “Marked comment as helpful”
* Pressing again the “thumb up” icon  decreases the “thumb up” counter, turns the thumb up color to grey and prompts a notification to the helpee at the bottom of the screen: “Removed  comment as helpful”
* A helpee can only mark as helpful a comment on a discussion thread he did not create. A helpee won’t see “thumbs up” icons on discussion threads he created but rather “Mark question as solved” buttons (addressed in another user story)
* Marking a comment as helpful will disable OS notifications on comments posted on this discussion thread.
* A discussion thread with a comment marked as helpful will start showing-up in suggested answers.

Attachments

(1 file)

      No description provided.
Depends on: 1074954
Summary: [User Story] As a Helpee I can mark as helpful an existing discussion thread, so that I can notify the helper that I have an answer to my question. → [User Story] As a Helpee I can mark as helpful a specific comment, so that I can notify the helper that his comment helped me.
Priority: -- → P2
Target Milestone: --- → 2014Q4
User Story: (updated)
Depends on: 1090230
User Story: (updated)
"A “thumb up” icon is displayed on each helper comment with a number indicating the number of times it’s been selected by individual helpees"

Two things:

1) I do not believe we know whether a comment was made by a helper or helpee currently. Is this something that should be added to the Answer API?
2) Can helpers vote for comments made by other helpers? I cannot imagine that only one helper can ever be active on a question, and even then, another could view the question which would then allow them to vote on a comment if they so desire.

Regarding point 1, we could have a property called role on the user object on the server and then, for generated users, one can set this to helpee. We could then for each answer call the server to determine whether the user is a helpee but, this would be horrible when there are a lot of comments on a question (actually in general) so, we should perhaps explore adding the role property to the answers API instead.

So, something like:

"creator": {
    "username": "BigYellowFox552", 
    "display_name": null,
    "role": "helpee"
},
Flags: needinfo?(mcooper)
Flags: needinfo?(a.topal)
Assignee: nobody → schalk.neethling.bugs
Romain[:RT],

* Marking a comment as helpful will disable OS notifications on comments posted on this discussion thread.
* A discussion thread with a comment marked as helpful will start showing-up in suggested answers.

Should these be 'When a comment has been marked as a solution'?
Flags: needinfo?(rtestard)
I'm uncomfortable adding a role column to the user model. What happens when a user both asks and answers questions? This distinction has always been very arbitrary to me, and I don't think it is logically consistent to encode in the API.

On the other hand, I do think that anyone who is commenting on questions not their own is helping. So instead of having a role on each user, could you compare the author of the question against the author of the answer? Anyone who is not the OP is a helper, and the OP is a helpee.
Flags: needinfo?(mcooper)
(In reply to Mike Cooper [:mythmon] from comment #3)
> On the other hand, I do think that anyone who is commenting on questions not
> their own is helping. So instead of having a role on each user, could you
> compare the author of the question against the author of the answer?

Thinking about this again, it is actually pretty simple for me. Basically the only people the can comment on a question, and :RT can correct me here if I am wrong, is the author of the question and logged in Helpers.

So, any comment/answer on a thread that is not posted by the author of the question, would have been posted by a helper, and I can therefore add the voting icon to it.

Thanks for the feedback :mythmon
Blocks: 1109642
Flags: needinfo?(a.topal)
Whiteboard: p=1
Status: NEW → ASSIGNED
(In reply to Schalk Neethling [:espressive] from comment #4)
> (In reply to Mike Cooper [:mythmon] from comment #3)
> > On the other hand, I do think that anyone who is commenting on questions not
> > their own is helping. So instead of having a role on each user, could you
> > compare the author of the question against the author of the answer?
> 
> Thinking about this again, it is actually pretty simple for me. Basically
> the only people the can comment on a question, and :RT can correct me here
> if I am wrong, is the author of the question and logged in Helpers.
> 
Any helpee can comment on a thread regardless of whether they created it or not. 
> So, any comment/answer on a thread that is not posted by the author of the
> question, would have been posted by a helper, and I can therefore add the
> voting icon to it.
> 
> Thanks for the feedback :mythmon
Flags: needinfo?(rtestard)
Whiteboard: p=1 → p=1 s=bu.2014.4
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Whiteboard: p=1 s=bu.2014.4 → p=1 s=bu.2015.1
User Story: (updated)
Attachment #8550878 - Flags: review?(rdalal)
Attachment #8550878 - Flags: review?(anthony)
Comment on attachment 8550878 [details] [review]
https://github.com/mozilla/buddyup/pull/54

A few nits for code organisation.
But we also need to change the style of the vote button after a vote.
Attachment #8550878 - Flags: review?(rdalal)
Attachment #8550878 - Flags: review?(anthony)
(In reply to Anthony Ricaud (:rik) from comment #8)
> Comment on attachment 8550878 [details] [review]
> https://github.com/mozilla/buddyup/pull/54
> 
> A few nits for code organisation.
> But we also need to change the style of the vote button after a vote.

Ah yes, it needs to be blue. forgot about that.
Schalk: Can we try to land this before sprint review today?
Flags: needinfo?(schalk.neethling.bugs)
I addressed my review comments and landed this in https://github.com/mozilla/buddyup/commit/4a2f3bcee626c67a4d9fc9ff2c7511e7df84e0b1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(schalk.neethling.bugs)
Resolution: --- → FIXED
Please find below comments on 2 of the acceptance criteria that failed during QA.

Acceptance criteria:
* Pressing the “thumb up” icon increases the “thumb up” counter, turns the thumb up color to blue and prompts a notification to the helpee at the bottom of the screen: “Marked comment as helpful”

- The "thump up" counter increased, changed color but a notification didn't appear.

* Pressing again the “thumb up” icon  decreases the “thumb up” counter, turns the thumb up color to grey and prompts a notification to the helpee at the bottom of the screen: “Removed  comment as helpful”

- It didn't decrease the "thumb up" counter at all neither a notification appeared. It only turned the thumb up color to grey.
Flags: needinfo?(a.topal)
yes, acceptance criteria mentioned above are correct. I'll open 3 separate bugs.
I filed bug 1145725 and bug 1145726
Flags: needinfo?(a.topal)
Flags: in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: