1061561 - [User Story] As a Helpee I can mark a comment as resolution of a discussion thread I created, so that I can notify the helper that I have an answer to my question and I stop receiving notifications..

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect, P2)

Comment 1

[Kadir Topal [:atopal]]

The way this is implemented is changing. Instead of a dedicated "mark a solved" button, we repurpose the "mark as helpful" button in the following way: If the question asker marks a post as helpful, we count that as "mark as solved". For everyone else we'll continue counting the vote as a simple "mark as helpful".

Comment 2

[Schalk Neethling [:espressive]]

I believe the below is no longer relevant based on comment 1

* A “Mark question as solved” button is displayed on each helper comment of a discussion thread a helpee created
* Pressing the “Mark question as solved” button prompts a new screen asking the helpee to confirm his choice. The helpee can confirm or discard to get back to the discussion thread.

Comment 3

[Romain Testard [:RT]]

(In reply to Schalk Neethling [:espressive] from comment #2)
> I believe the below is no longer relevant based on comment 1
> 
> * A “Mark question as solved” button is displayed on each helper comment of
> a discussion thread a helpee created
> * Pressing the “Mark question as solved” button prompts a new screen asking
> the helpee to confirm his choice. The helpee can confirm or discard to get
> back to the discussion thread.

Kadir can you clarify here. I believe your comment is now not applicable anymore but please confirm?

Comment 4

[Kadir Topal [:atopal]]

Yes, confirming. The relevant slide in the UX document is titled "Helpee - Mark My Question as Solved"

Comment 5

[Anthony Ricaud (:rik)]

Can we still comment on a question after it has been marked as solved?

Also I'm thinking we should automatically mark the comment with the solution as helpful. But that's just a thought.

Comment 6

[Schalk Neethling [:espressive]]

And to follow on from Anthony's question, can one still vote for comments as helpful on a question that has been marked as solved? or is everything disabled.

Comment 7

[Romain Testard [:RT]]

(In reply to Anthony Ricaud (:rik) from comment #5)
> Can we still comment on a question after it has been marked as solved?
> 
I think we should not or it will get very messy and we'll start getting into issues such as:
* Does this mean this should be treated as a new question? In this case we'd be better off letting the user submit a new question.
* Hard to read the flow, further comments may be asking for other things on a related subject.

I NI Hermina here to check if I'm not missing something here.
> Also I'm thinking we should automatically mark the comment with the solution
> as helpful. But that's just a thought.
Yes good idea, just updated the US

Comment 8

[Romain Testard [:RT]]

(In reply to Schalk Neethling [:espressive] from comment #6)
> And to follow on from Anthony's question, can one still vote for comments as
> helpful on a question that has been marked as solved? or is everything
> disabled.
Users should be able to still vote for comments as helpful on a solved question. This will let users who search for questions provide feedback.

I made it clearer on the US of bug 1061559

Comment 9

[Kadir Topal [:atopal]]

Thanks, Romain! I agree, we should close the threads as soon as they are marked as solved. Unfortunately that will also remove any chance for the helpee to say "thank you", unless they did that before marking the thread as solved.

Comment 10

[Kadir Topal [:atopal]]

moving to next sprint

Comment 11

[Anthony Ricaud (:rik)]

Mike: Can you share the API endpoint to mark an answer as solving a question?

Comment 12

[Michael Cooper [:mythmon]]

I'm not sure why I wasn't able to find this earlier, but here it is. The API view is here: https://github.com/mozilla/kitsune/blob/master/kitsune/questions/api.py#L202

This is an instance action on Question endpoints, and it takes an answer id as a parameter. To mark question 123 as solved by answer 456, the request would be this: (with authentication of course)

    http POST /api/2/question/123/solve/?answer=456

It should be the case that only the creator of a question can mark the question as solved.

Comment 13

[Anthony Ricaud (:rik)]

So actually, we need to pass the answer field in the body instead of the query string.
(side note: linking to master is confusing because code evolves and the line you point changes. You can press 'y' on github to give you a link to the exact commit and not 'master')

Comment 14

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla/buddyup/pull/67

Comment 15

[Rehan Dalal (Inactive)]

Comment on attachment 8557021 [details] [review]
https://github.com/mozilla/buddyup/pull/67

lgtm. works as expected! r+

Comment 16

[Anthony Ricaud (:rik)]

https://github.com/mozilla/buddyup/commit/11fe2eab845015fda52b89975312e851b3982d12

Comment 17

[Christos Bacharakis]

I couldn't check this, due to another bug 1136045

Comment 18

[Christos Bacharakis]

As a helper I wasn't able to receive any notification when my comment was marked as resolution of the discussion thread.