Add tests directory's javascript files to .jshintignore

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ShellHacker, Assigned: ShellHacker, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
This bug has to be first fixed, so that the tracker bug 1061513 can be completed.

For detailed instructions on how to fix this, look at comment 2 on bug 1057770
Mentor: yurenju.mozilla@gmail.com
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 2

3 years ago
Created attachment 8485411 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23783

Hi, This removes the blocker put up in comment 4 on Bug 1057770 and makes Bug 1061513 workable.
Assignee: nobody → sudheesh1995
Status: NEW → ASSIGNED
Attachment #8485411 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
Comment on attachment 8485411 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23783

Sudheesh, the pull request didn't pass lint test on try server because you have two typo in your commit

please check it and send review request again if the pull can pass lint test.
Attachment #8485411 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
(Assignee)

Comment 4

3 years ago
I had 3 typo when I rechecked, Fixed them this time. I am not sure why the new line after the jsonmoztest.js hasn't reflected even though I have it locally.
(Assignee)

Updated

3 years ago
Attachment #8485411 - Flags: review?(yurenju.mozilla)
Comment on attachment 8485411 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23783

Sudheesh, I used a script to check if file exists, there are the file does not exists which are added in your commit:

> tests/browser_dialer_contats_edition.js
> tests/browser_sms_conversations.js
> tests/gaia_data_layer.js
> tests/gaia_lock_screen.js
> tests/reflow.js
> tests/remote_date.js
> tests/screenshot.js

please check it again.

BTW, this is the script which I used for checking files. https://gist.github.com/yurenju/3f51bd613d3237dd5c44
Attachment #8485411 - Flags: review?(yurenju.mozilla)
(Assignee)

Comment 6

3 years ago
Comment on attachment 8485411 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23783

Fixed and checked everything again. This time it should be fine.
Attachment #8485411 - Flags: review?(yurenju.mozilla)
Comment on attachment 8485411 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23783

Sudheesh, please get Li green before you request review.

https://tbpl.mozilla.org/?rev=6e0f5fe880d090fe064b32a07766f19645eb0a3d&tree=Gaia-Try
Attachment #8485411 - Flags: review?(yurenju.mozilla)
(Assignee)

Comment 8

3 years ago
Li is green now after changes in the marionette_js_stable_check/ folder. Is it good to go now ?
(Assignee)

Updated

3 years ago
Attachment #8485411 - Flags: review?(yurenju)
Comment on attachment 8485411 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23783

looks good!
Attachment #8485411 - Flags: review?(yurenju) → review+
merged.

https://github.com/mozilla-b2g/gaia/commit/865729733fe7905862a8356ad5b7f4ee2f842fef
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
This is wrong, these files should've been added to xfail.list instead.
Thank you very much for the patch, we should've caught this in review though. It does't matter to me if we remove these as we fix them, but let's please avoid adding more stuff to the .jshintignore for the time being.
You need to log in before you can comment on or make changes to this bug.