1061618 - about:preferences shows blank pages

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Octoploid]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20140902141435

Steps to reproduce:

Open about:preferences


Actual results:

The preferences aren't shown. All I see is a blank page.
See attached screenshop

Comment 1

[Octoploid]

Attachment: 2014-09-02-143029_1050x1680_scrot.png

Comment 2

[:Gijs (out for now; he/him)]

Can you reproduce in a clean profile? Are there any errors in the browser console?

Comment 3

[Octoploid]

(In reply to :Gijs Kruitbosch from comment #2)
> Can you reproduce in a clean profile? 

Yes.

> Are there any errors in the browser console?

No.

Comment 4

[YF (Yang)]

Any response when switching left-tabs?
It was normal in previous versions?

Looks like the #mainPrefPane is not loaded.

I have not reproduce the on latest Nightly in Windows 8.1.
Built from https://hg.mozilla.org/mozilla-central/rev/532b5fb77ba1.

Comment 5

[:Gijs (out for now; he/him)]

I also can't reproduce on either OS X or Linux, on today's Nightly...

Comment 6

[Octoploid]

(In reply to YF (Yang) from comment #4)
> Any response when switching left-tabs?

No.

> It was normal in previous versions?

Yes. I build trunk almost daily. It worked a few days ago.

Comment 7

[:Gijs (out for now; he/him)]

(In reply to Octoploid from comment #6)
> (In reply to YF (Yang) from comment #4)
> > Any response when switching left-tabs?
> 
> No.
> 
> > It was normal in previous versions?
> 
> Yes. I build trunk almost daily. It worked a few days ago.

You build trunk yourself? Have you tried an official build as well, and does it have the same problem?

Comment 8

[Octoploid]

(In reply to :Gijs Kruitbosch from comment #7)
> (In reply to Octoploid from comment #6)
> > (In reply to YF (Yang) from comment #4)
> > > Any response when switching left-tabs?
> > 
> > No.
> > 
> > > It was normal in previous versions?
> > 
> > Yes. I build trunk almost daily. It worked a few days ago.
> 
> You build trunk yourself? 

yes.

>Have you tried an official build as well, and does it have the same problem?

official build is fine (I tried latest nightly: Source Built from https://hg.mozilla.org/mozilla-central/rev/c360f3d1c00d)

Comment 9

[Octoploid]

markus@x4 mozilla-central % cat .mozconfig
. $topsrcdir/browser/config/mozconfig

ac_add_options --prefix=/usr
ac_add_options --libdir=/usr/lib

ac_add_options --with-system-jpeg --with-pthreads --with-system-zlib
ac_add_options --with-system-bz2 --with-system-hunspell
ac_add_options --with-system-libevent
ac_add_options --with-system-lcms 
ac_add_options --with-system-png
ac_add_options --with-system-icu
ac_add_options --with-system-libvpx
ac_add_options --with-system-ffmpeg
ac_add_options --enable-system-ffi
ac_add_options --enable-system-pixman 
ac_add_options --enable-system-sqlite
ac_add_options --disable-gstreamer --disable-content-sandbox
#ac_add_options --with-system-nss --with-system-nspr

ac_add_options --disable-installer --disable-updater
ac_add_options --enable-official-branding
ac_add_options --enable-startup-notification
ac_add_options --disable-necko-wifi --disable-accessibility
ac_add_options --disable-elf-hack
ac_add_options --disable-sync
#ac_add_options --disable-stdcxx-compat
ac_add_options --disable-pulseaudio 
#ac_add_options --disable-unified-compilation

ac_add_options --disable-jemalloc
ac_add_options --enable-optimize=-O3 --disable-debug --disable-tests
ac_add_options --disable-debug-symbols
ac_add_options --disable-strip --disable-install-strip

ac_add_options --enable-default-toolkit=cairo-gtk2 --enable-system-cairo

ac_add_options --disable-crashreporter --disable-parental-controls
ac_add_options --disable-safe-browsing
#ac_add_options --disable-skia
#ac_add_options --disable-webrtc

mk_add_options MOZ_OBJDIR=/var/tmp/moz-build-dir
mk_add_options MOZ_MAKE_FLAGS="-j4"

export CFLAGS="-ffunction-sections -fdata-sections "
export CXXFLAGS="-ffunction-sections -fdata-sections "

Comment 10

[:Gijs (out for now; he/him)]

(In reply to Octoploid from comment #9)
> markus@x4 mozilla-central % cat .mozconfig
> . $topsrcdir/browser/config/mozconfig


It's going to be one of these switches that broke... but it'll be tricky to figure out which one for anyone but you (also because it might depend on what versions of what system libs you're building with).

Can you try narrowing the regression range a bit?

Alternatively, considering it's specific to about:preferences, I would almost wonder if it's --disable-sync... - but that's just a guess. Could also try to bisect the mozconfig, I guess?

Comment 11

[Octoploid]

Aug 26 16:04 build is fine
Aug 29 13:59 build is buggy

will bisect later.

Comment 12

[Octoploid]

Started with:
800723ca6a75c18916bd5bdb43928bc8755d4d49 is the first bad commit
commit 800723ca6a75c18916bd5bdb43928bc8755d4d49
Author: Sebastian Hengst <[e-mail]>
Date:   Wed Aug 27 00:08:49 2014 +0200

    Bug 1016300 - Move inline scripts and styles into separate files for in-content preferences. r=Gijs

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Are there any errors in the browser console after opening the preferences? If yes, can you please post them here?

Comment 14

[Octoploid]

(In reply to Archaeopteryx [:aryx] from comment #13)
> Are there any errors in the browser console after opening the preferences?
> If yes, can you please post them here?

TypeError: document.getElementById(...) is null advanced.js:20

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

The reason for this bug is that with updater disabled, the code failed because the node "showUpdateHistory" was not in the ifdef MOZ_UPDATER block.

Furthermore, I spotted that one creation of an event listener had the wrong node and wrong event type.

I built Firefox with installer and updater enabled and the preferences work without throwing an error.

Comment 16

[:Gijs (out for now; he/him)]

Comment on attachment 8482844 [details] [diff] [review]
patch, v1

Review of attachment 8482844 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 17

[Carsten Book [:Tomcat]]

Hi, could you provide a try link thanks!

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=7f904bc93f4c

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b56ee08673c

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8482844 [details] [diff] [review]
patch, v1

Please just use the checkin-needed keyword. It works better with automated bug marking tools.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b56ee08673c

Comment 22

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]: This is a regression from the changes in bug 1016300. Not fixing it on Aurora will break the Preferences in builds without updater.

Comment 23

[:Gijs (out for now; he/him)]

Comment on attachment 8482844 [details] [diff] [review]
patch, v1

Approval Request Comment
[Feature/regressing bug #]: bug 1016300
[User impact if declined]: builds without updater (e.g. linux distro builds, I suspect?) have broken in-content preferences
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: very low - in-content prefs are not the default, and this was mostly just moving ifdefs about.
[String/UUID change made/needed]: none

Comment 24

[:Gijs (out for now; he/him)]

(don't think we need to track this - but we should uplift)

Comment 25

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to :Gijs Kruitbosch from comment #24)
> (don't think we need to track this - but we should uplift)

Tracking as I don't want to ship broken prefs to linux distros.

Comment 26

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8482844 [details] [diff] [review]
patch, v1

Aurora+

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/868cc9e5e32a

FWIW, we have bug queries for branch uplifts. You don't need to set checkin-needed for it to be found :)